public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hans-Christian Noren Egtvedt <hegtvedt@cisco.com>
Cc: linux-kernel@vger.kernel.org,
	Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH v4.4/bluetooth 1/2] Bluetooth: Consolidate encryption handling in hci_encrypt_cfm
Date: Thu, 15 Oct 2020 11:57:50 +0200	[thread overview]
Message-ID: <20201015095750.GA3935178@kroah.com> (raw)
In-Reply-To: <20201015074333.445510-1-hegtvedt@cisco.com>

On Thu, Oct 15, 2020 at 09:43:32AM +0200, Hans-Christian Noren Egtvedt wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This makes hci_encrypt_cfm calls hci_connect_cfm in case the connection
> state is BT_CONFIG so callers don't have to check the state.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> (cherry picked from commit 3ca44c16b0dcc764b641ee4ac226909f5c421aa3)

This is only in 5.8, what about all the other stable kernels?

> (cherry picked from commit 0a60996c7fa7010ea00d9b62fb6996d908a01ead)

Where is this commit from?  I don't see it in Linus's tree.

> ---
> AFAICT, fixing CVE 2020-10135 Bluetooth impersonation attacks have been
> left out for the 4.4 stable kernel. I cherry picked what I assume are
> the appropriate two patches missing from the 4.9 stable kernel. Please
> add them to upcoming 4.4 stable releases.

Why are you merging 2 commits together?  Please provide backports for
all stable kernels, if you want to see this in the 4.4.y tree.  We can
not have someone move from an older tree to a newer one and have a
regression.

thanks,

greg k-h

  parent reply	other threads:[~2020-10-15  9:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  7:43 [PATCH v4.4/bluetooth 1/2] Bluetooth: Consolidate encryption handling in hci_encrypt_cfm Hans-Christian Noren Egtvedt
2020-10-15  7:43 ` [PATCH v4.4/bluetooth 2/2] Bluetooth: Disconnect if E0 is used for Level 4 Hans-Christian Noren Egtvedt
2020-10-15  9:58   ` Greg KH
2020-10-15  9:57 ` Greg KH [this message]
2020-10-15 11:18   ` [PATCH v4.4/bluetooth 1/2] Bluetooth: Consolidate encryption handling in hci_encrypt_cfm Hans-Christian Egtvedt (hegtvedt)
2020-10-15 12:02     ` Greg KH
2020-10-15 12:44       ` Hans-Christian Egtvedt (hegtvedt)
2020-10-15 21:15         ` Hans-Christian Egtvedt (hegtvedt)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015095750.GA3935178@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hegtvedt@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox