From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6DDC43457 for ; Thu, 15 Oct 2020 10:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 321EA22249 for ; Thu, 15 Oct 2020 10:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727200AbgJOKuI (ORCPT ); Thu, 15 Oct 2020 06:50:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:10477 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbgJOKuH (ORCPT ); Thu, 15 Oct 2020 06:50:07 -0400 IronPort-SDR: PWZsg1gTud0v72FYPadAcSHLG3n6z3eVlcDoz6GmB0dEkQKoln1e4o9+uzWp35G8vSdc+cJK4y +gjbMLrgwGYw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="153246165" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="153246165" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:50:07 -0700 IronPort-SDR: XRJgxpgsxB4D8wBiqZnKJX82Bk4f1AUWT+2R8p9xT6iB3rw/VzqF/BhBLRPBXaIElicUARBrwz Ddg00+IephIg== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="330757409" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:50:03 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kT0qf-007N8B-4h; Thu, 15 Oct 2020 13:51:05 +0300 Date: Thu, 15 Oct 2020 13:51:05 +0300 From: Andy Shevchenko To: Vitor Massaru Iha Cc: kunit-dev@googlegroups.com, brendanhiggins@google.com, elver@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, gregkh@linuxfoundation.org, tglx@linutronix.de, geert@linux-m68k.org, paul.gortmaker@windriver.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, arnd@arndb.de, elfring@users.sourceforge.net, mhocko@suse.com Subject: Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit Message-ID: <20201015105105.GS4077@smile.fi.intel.com> References: <20201015014616.309000-1-vitor@massaru.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015014616.309000-1-vitor@massaru.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote: > This adds the conversion of the runtime tests of test_list_sort, > from `lib/test_list_sort.c` to KUnit tests. Please, provide better commit message. For example, add the output of _succeeded_ *and* _failed_ test cases (yes, you have to break code manually to reproduce failed test cases) _before_ *and* _after_ the change. W/o above information I'm going to NAK this as I promised before. -- With Best Regards, Andy Shevchenko