From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1DFC433DF for ; Thu, 15 Oct 2020 10:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7762D22249 for ; Thu, 15 Oct 2020 10:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728938AbgJOKaC convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2020 06:30:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:38702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728292AbgJOKaB (ORCPT ); Thu, 15 Oct 2020 06:30:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C8ACAD1E; Thu, 15 Oct 2020 10:29:59 +0000 (UTC) Date: Thu, 15 Oct 2020 12:29:57 +0200 From: Thomas Zimmermann To: Tian Tao Cc: , , , , , , , , Subject: Re: [PATCH drm/hisilicon v2 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv Message-ID: <20201015122957.6590adb3@linux-uq9g> In-Reply-To: <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> References: <1602752417-20598-1-git-send-email-tiantao6@hisilicon.com> <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Thu, 15 Oct 2020 17:00:17 +0800 Tian Tao wrote: > Consistently Use the same style of variable type in hibmc_drm_drv.c and > hibmc_drm_drv.h. > > Signed-off-by: Tian Tao > Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 ++++++------- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 8 ++++---- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 5632bce..0c1b40d > 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > @@ -121,12 +121,11 @@ static void hibmc_kms_fini(struct hibmc_drm_private > *priv) /* > * It can operate in one of three modes: 0, 1 or Sleep. > */ > -void hibmc_set_power_mode(struct hibmc_drm_private *priv, > - unsigned int power_mode) > +void hibmc_set_power_mode(struct hibmc_drm_private *priv, u32 power_mode) > { > - unsigned int control_value = 0; > + u32 control_value = 0; > void __iomem *mmio = priv->mmio; > - unsigned int input = 1; > + u32 input = 1; > > if (power_mode > HIBMC_PW_MODE_CTL_MODE_SLEEP) > return; > @@ -144,8 +143,8 @@ void hibmc_set_power_mode(struct hibmc_drm_private > *priv, > void hibmc_set_current_gate(struct hibmc_drm_private *priv, unsigned int > gate) { > - unsigned int gate_reg; > - unsigned int mode; > + u32 gate_reg; > + u32 mode; > void __iomem *mmio = priv->mmio; > > /* Get current power mode. */ > @@ -170,7 +169,7 @@ void hibmc_set_current_gate(struct hibmc_drm_private > *priv, unsigned int gate) > static void hibmc_hw_config(struct hibmc_drm_private *priv) > { > - unsigned int reg; > + u32 reg; > > /* On hardware reset, power mode 0 is default. */ > hibmc_set_power_mode(priv, HIBMC_PW_MODE_CTL_MODE_MODE0); > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h index 6a63502..5c4030d > 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > @@ -33,8 +33,8 @@ struct hibmc_drm_private { > /* hw */ > void __iomem *mmio; > void __iomem *fb_map; > - unsigned long fb_base; > - unsigned long fb_size; > + u64 fb_base; > + u64 fb_size; No comment on why u64 is better than resource_size_t ? Best regards Thomas > > /* drm */ > struct drm_device *dev; > @@ -56,9 +56,9 @@ static inline struct hibmc_drm_private > *to_hibmc_drm_private(struct drm_device * } > > void hibmc_set_power_mode(struct hibmc_drm_private *priv, > - unsigned int power_mode); > + u32 power_mode); > void hibmc_set_current_gate(struct hibmc_drm_private *priv, > - unsigned int gate); > + u32 gate); > > int hibmc_de_init(struct hibmc_drm_private *priv); > int hibmc_vdac_init(struct hibmc_drm_private *priv); -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer