From: Daniel Vetter <daniel@ffwll.ch>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: Sandy Huang <hjc@rock-chips.com>,
heiko@sntech.de,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
huangtao@rock-chips.com, andy.yan@rock-chips.com,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Date: Thu, 15 Oct 2020 17:23:01 +0200 [thread overview]
Message-ID: <20201015152301.GE438822@phenom.ffwll.local> (raw)
In-Reply-To: <5c0cdb9d-8e35-fa0c-35b3-adfa7770fb30@rock-chips.com>
On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> Hi Maintainers,
>
> Does this patch ready to merge?
Would maybe be good to get some acks from other drivers using this, then
Sandy can push to drm-misc-next.
-Daniel
>
> On 2020/7/7 下午7:25, Sandy Huang wrote:
> > don't mask possible_crtcs if remote-point is disabled.
> >
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > ---
> > drivers/gpu/drm/drm_of.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..565f05f5f11b 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> > uint32_t possible_crtcs = 0;
> > for_each_endpoint_of_node(port, ep) {
> > + if (!of_device_is_available(ep))
> > + continue;
> > +
> > remote_port = of_graph_get_remote_port(ep);
> > if (!remote_port) {
> > of_node_put(ep);
>
> Looks good to me.
>
>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-10-15 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
2020-07-07 11:33 ` Heiko Stübner
2020-07-22 19:01 ` Heiko Stübner
2020-08-13 6:31 ` Huang Jiachai
2020-09-02 11:56 ` Huang Jiachai
2020-10-14 1:48 ` Kever Yang
2020-10-15 15:23 ` Daniel Vetter [this message]
2020-10-19 3:43 ` Kever Yang
2020-10-20 8:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015152301.GE438822@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox