From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5BFC433DF for ; Fri, 16 Oct 2020 10:56:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43ADA2145D for ; Fri, 16 Oct 2020 10:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395562AbgJPK43 convert rfc822-to-8bit (ORCPT ); Fri, 16 Oct 2020 06:56:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:35088 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395510AbgJPK42 (ORCPT ); Fri, 16 Oct 2020 06:56:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD1D7AF2C; Fri, 16 Oct 2020 10:56:26 +0000 (UTC) Date: Fri, 16 Oct 2020 12:56:25 +0200 From: Thomas Zimmermann To: Xu Wang Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201016125625.7d2b5bd7@linux-uq9g> In-Reply-To: <20201015101015.6dbd25ce@linux-uq9g> References: <20201014085722.26069-1-vulab@iscas.ac.cn> <20201015101015.6dbd25ce@linux-uq9g> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 10:10:15 +0200 Thomas Zimmermann wrote: > On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang > > Reviewed-by: Thomas Zimmermann > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > > { > > if (atomic_inc_and_test(&priv->hw_usecnt)) { > > - if (priv->dot_clk) > > - clk_prepare_enable(priv->dot_clk); > > + clk_prepare_enable(priv->dot_clk); > > pm_runtime_get_sync(priv->dev); > > } > > } > > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > > sh_mobile_lcdc_priv *priv) { > > if (atomic_sub_return(1, &priv->hw_usecnt) == -1) { > > pm_runtime_put(priv->dev); > > - if (priv->dot_clk) > > - clk_disable_unprepare(priv->dot_clk); > > + clk_disable_unprepare(priv->dot_clk); > > } > > } > > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer