From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C032FC433E7 for ; Fri, 16 Oct 2020 04:05:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66577207F7 for ; Fri, 16 Oct 2020 04:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602821152; bh=vsrcDgb66ZZHroPzoaTCBR+9WG8G0fK5ozU28secHx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=I/NdZeBtzQLCBJqdgytRPE0ysFNqdPtUChjKkcRlhpM8btk8FX3mlfLyyyB6Zvlla A0CsYnWfDuF9LFZb13//tAL3HBIX6vpxG6oNCxXwiy9f1wQHQ7lVDQUE6fyrQoIygU QDqEyVjyCu3BAHOUG5gMfNJphVEk01GHjgGMQwrY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgJPEFu (ORCPT ); Fri, 16 Oct 2020 00:05:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:59078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbgJPEFu (ORCPT ); Fri, 16 Oct 2020 00:05:50 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A0632076E; Fri, 16 Oct 2020 04:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602821150; bh=vsrcDgb66ZZHroPzoaTCBR+9WG8G0fK5ozU28secHx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T8tnutUhi2yjg6rfrO0cFXVUYv4ruo168k2OL0XXlWhD3/0RG79YNCvlRtrxL37y4 UzyrQmXVJpU0IgKt9Qk3Ehw3GVLFenFKrjbM9FToz52SRCujeDMV9JInlqI0t16pQu 73YcxtvWGjlT9evFO2MjKURwR4pKHhllVidIhtf8= Date: Fri, 16 Oct 2020 13:05:45 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Linus Torvalds , LKML , Ingo Molnar , Andrew Morton , Tom Zanussi Subject: Re: [GIT PULL] tracing: Updates for 5.10 Message-Id: <20201016130545.caea7a3312ca2ee32990af61@kernel.org> In-Reply-To: <20201015235444.6f222746@gandalf.local.home> References: <20201015135345.6b29e8c0@gandalf.local.home> <20201015222139.1b92a3be@gandalf.local.home> <20201016115323.13a75e51d5dc18573de4d33a@kernel.org> <20201015235444.6f222746@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 23:54:44 -0400 Steven Rostedt wrote: > On Fri, 16 Oct 2020 11:53:23 +0900 > Masami Hiramatsu wrote: > > > > > > > I'll have to think about how to untangle this. Is there some kind of > > > annotation that makes it show that a path can only be called at boot up and > > > not later? > > > > What happen if we use Peter's static_call() and update it after boot up? > > I think that's a bit over engineering ;-) > > > Or, we might need to break apart the trace_array_create() and restruct > > it as __init trace_array_early_create() and trace_array_create(). > > That will likely make the code a bit more complex and possibly add as much > code as we save from the __init sections. > > I think the best solution is what you proposed, and removing the __init, > and possibly making that function inline as well. > > Care to send an official patch? Sure, I'll send it. Thank you, -- Masami Hiramatsu