Re: [PATCH v1 4/6] spi: cadence-quadspi: Add QSPI support for Intel LGM SoC

Mark Brown
2020-10-16T16:33:29Z

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Fri, Oct 16, 2020 at 05:31:36PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> + depends on OF && (ARM || ARM64 || X86 || COMPILE_TEST)

> + {
> + .compatible = "intel,lgm-qspi",
> + },

This is an x86 SoC (or SoC series) - is it really going to use DT for
the firmware interfaces? It's not specifically a problem, just
surprising to see something other than ACPI. Or is the intention to use
PRP0001? There's a new comaptible here which wasn't really the use case
for PRP0001. Like I say not really a problem, just curious.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]