From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch,
robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
zhang.lyra@gmail.com
Subject: Re: [PATCH RFC v7 0/6] Add Unisoc's drm kms module
Date: Fri, 16 Oct 2020 21:08:21 +0200 [thread overview]
Message-ID: <20201016190821.GC1345100@ravnborg.org> (raw)
In-Reply-To: <1601274460-7866-1-git-send-email-kevin3.tang@gmail.com>
Hi Kevin,
> v7:
> 1. Fix DTC unit name warnings
> 2. Fix the problem of maintainers
> 3. Call drmm_mode_config_init to mode config init
> 4. Embed drm_device in sprd_drm and use devm_drm_dev_alloc
> 5. Replace DRM_XXX with drm_xxx on KMS module, but not suitable for other subsystems
> 6. Remove plane_update stuff, dpu handles all the HW update in crtc->atomic_flush
> 7. Dsi&Dphy Code structure adjustment, all move to "sprd/"
I can see some of my feedback from last round of review is not
addressed. There were makefile fixes and then I asked for a high-level
intro.
Can you please revisit last round of review feedback to check what was
missed.
Sam
>
> Kevin Tang (6):
> dt-bindings: display: add Unisoc's drm master bindings
> drm/sprd: add Unisoc's drm kms master
> dt-bindings: display: add Unisoc's dpu bindings
> drm/sprd: add Unisoc's drm display controller driver
> dt-bindings: display: add Unisoc's mipi dsi&dphy bindings
> drm/sprd: add Unisoc's drm mipi dsi&dphy driver
>
> .../display/sprd/sprd,display-subsystem.yaml | 39 +
> .../bindings/display/sprd/sprd,sharkl3-dpu.yaml | 83 ++
> .../display/sprd/sprd,sharkl3-dsi-host.yaml | 98 ++
> .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 +
> drivers/gpu/drm/Kconfig | 2 +
> drivers/gpu/drm/Makefile | 1 +
> drivers/gpu/drm/sprd/Kconfig | 13 +
> drivers/gpu/drm/sprd/Makefile | 12 +
> drivers/gpu/drm/sprd/dpu_r2p0.c | 636 +++++++++
> drivers/gpu/drm/sprd/dw_dsi_ctrl.c | 792 +++++++++++
> drivers/gpu/drm/sprd/dw_dsi_ctrl.h | 1475 ++++++++++++++++++++
> drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c | 276 ++++
> drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h | 34 +
> drivers/gpu/drm/sprd/megacores_pll.c | 315 +++++
> drivers/gpu/drm/sprd/megacores_pll.h | 146 ++
> drivers/gpu/drm/sprd/sprd_dphy.c | 335 +++++
> drivers/gpu/drm/sprd/sprd_dphy.h | 39 +
> drivers/gpu/drm/sprd/sprd_dpu.c | 501 +++++++
> drivers/gpu/drm/sprd/sprd_dpu.h | 217 +++
> drivers/gpu/drm/sprd/sprd_drm.c | 263 ++++
> drivers/gpu/drm/sprd/sprd_drm.h | 20 +
> drivers/gpu/drm/sprd/sprd_dsi.c | 1102 +++++++++++++++
> drivers/gpu/drm/sprd/sprd_dsi.h | 105 ++
> 23 files changed, 6579 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
> create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
> create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
> create mode 100644 drivers/gpu/drm/sprd/Kconfig
> create mode 100644 drivers/gpu/drm/sprd/Makefile
> create mode 100644 drivers/gpu/drm/sprd/dpu_r2p0.c
> create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.c
> create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.h
> create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c
> create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h
> create mode 100644 drivers/gpu/drm/sprd/megacores_pll.c
> create mode 100644 drivers/gpu/drm/sprd/megacores_pll.h
> create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.c
> create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.h
> create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.c
> create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.h
> create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c
> create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h
> create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.c
> create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.h
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-10-16 19:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 6:27 [PATCH RFC v7 0/6] Add Unisoc's drm kms module Kevin Tang
2020-09-28 6:27 ` [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2020-09-28 8:17 ` Maxime Ripard
2020-09-28 16:28 ` Rob Herring
2020-09-29 6:35 ` Kevin Tang
2020-09-29 7:47 ` Chunyan Zhang
2020-09-28 6:27 ` [PATCH RFC v7 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang
2020-09-28 6:27 ` [PATCH RFC v7 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2020-09-28 6:27 ` [PATCH RFC v7 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2020-09-28 6:27 ` [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2020-09-28 8:20 ` Maxime Ripard
2020-09-28 11:29 ` Kevin Tang
2020-09-28 6:27 ` [PATCH RFC v7 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
2020-10-16 19:08 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016190821.GC1345100@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox