From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDD0C433E7 for ; Sun, 18 Oct 2020 19:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB3A8207DE for ; Sun, 18 Oct 2020 19:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049833; bh=OCj/8NsSojQ0BxbpC31Yz318JM50e/36vBJazaoYzYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rsD3hQiTHet/34T14PWzugmSNyxTfextfkM+FldN8SBiTdgKwsAIzmH4EEWLXydxC +a5+cMHKxR2QxIOV3JZo9YKojwauFQxKDBUWNDEPYsBYcbfRYbKkYjUyhRoCjGM/8J l2GCMJ9RPeAkPvuW5TwK0Dep6SL+nQbIylrJPPiE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732751AbgJRThM (ORCPT ); Sun, 18 Oct 2020 15:37:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731316AbgJRTZe (ORCPT ); Sun, 18 Oct 2020 15:25:34 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2DFF222E9; Sun, 18 Oct 2020 19:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049134; bh=OCj/8NsSojQ0BxbpC31Yz318JM50e/36vBJazaoYzYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bNT5zFfSNGLbMyJHkhJAQBObYUy+SBd/ZOfwN6eKxmnRfAYUeythLj4CTZmccOGX5 wkIfKSV691fr2LP8+iTUffcnboKnmaPlY0Cd6BmQijyVCV5RYHgTYnQEIXSL7MUk0l krBzMt1A00qnIluRtKJMU0e34Xr6URJdCS8nM1go= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oliver Neukum , syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com, Sean Young , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 03/52] media: ati_remote: sanity check for both endpoints Date: Sun, 18 Oct 2020 15:24:40 -0400 Message-Id: <20201018192530.4055730-3-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192530.4055730-1-sashal@kernel.org> References: <20201018192530.4055730-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum [ Upstream commit a8be80053ea74bd9c3f9a3810e93b802236d6498 ] If you do sanity checks, you should do them for both endpoints. Hence introduce checking for endpoint type for the output endpoint, too. Reported-by: syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/ati_remote.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c index d0871d60a7231..8e3af398a6c4e 100644 --- a/drivers/media/rc/ati_remote.c +++ b/drivers/media/rc/ati_remote.c @@ -845,6 +845,10 @@ static int ati_remote_probe(struct usb_interface *interface, err("%s: endpoint_in message size==0? \n", __func__); return -ENODEV; } + if (!usb_endpoint_is_int_out(endpoint_out)) { + err("%s: Unexpected endpoint_out\n", __func__); + return -ENODEV; + } ati_remote = kzalloc(sizeof (struct ati_remote), GFP_KERNEL); rc_dev = rc_allocate_device(RC_DRIVER_SCANCODE); -- 2.25.1