From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2468C433E7 for ; Sun, 18 Oct 2020 19:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82225207DE for ; Sun, 18 Oct 2020 19:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049817; bh=jaraSrj80zlYzpnw6JOPltVn8K5cA21AGwMQ4evNu7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y3sYdVZzuXyVgNaUMWezALW0rUMe3GowCzE8IZEzzW92I3w7aYCvA5JpSvlcQRPuR 4pFT2bYFWreELYwdZ+Y2IDF1M92Q7fYfWMcQ2tB3FnNL8DovqU8WdIKPJLeXYtpher ATY0ive7F/6+oKv/oi++oSDDaNIZcq+3AJP/R5I8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732846AbgJRTg4 (ORCPT ); Sun, 18 Oct 2020 15:36:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:41244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731589AbgJRT0L (ORCPT ); Sun, 18 Oct 2020 15:26:11 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93334222C8; Sun, 18 Oct 2020 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049171; bh=jaraSrj80zlYzpnw6JOPltVn8K5cA21AGwMQ4evNu7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B2CUFCTWOzUYnBg48YTUmQzl/lMDNqgCI7kNxlluj0qrg7PsZoGHNDsHr1VS8XdeG 6fSlQoskrKbWFhygAvZhOYOLXIydSi7+/kUTcFswOPnTGP4G8QfmZrRUIggSnin8XW vVUskGP3RJVSKLIVAqkYIFrLqjPlJMdDI9E+5+Qk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keita Suzuki , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 34/52] misc: rtsx: Fix memory leak in rtsx_pci_probe Date: Sun, 18 Oct 2020 15:25:11 -0400 Message-Id: <20201018192530.4055730-34-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192530.4055730-1-sashal@kernel.org> References: <20201018192530.4055730-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keita Suzuki [ Upstream commit bc28369c6189009b66d9619dd9f09bd8c684bb98 ] When mfd_add_devices() fail, pcr->slots should also be freed. However, the current implementation does not free the member, leading to a memory leak. Fix this by adding a new goto label that frees pcr->slots. Signed-off-by: Keita Suzuki Link: https://lore.kernel.org/r/20200909071853.4053-1-keitasuzuki.park@sslab.ics.keio.ac.jp Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/mfd/rtsx_pcr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c index 3cf69e5c57035..c9e45b6befacf 100644 --- a/drivers/mfd/rtsx_pcr.c +++ b/drivers/mfd/rtsx_pcr.c @@ -1268,12 +1268,14 @@ static int rtsx_pci_probe(struct pci_dev *pcidev, ret = mfd_add_devices(&pcidev->dev, pcr->id, rtsx_pcr_cells, ARRAY_SIZE(rtsx_pcr_cells), NULL, 0, NULL); if (ret < 0) - goto disable_irq; + goto free_slots; schedule_delayed_work(&pcr->idle_work, msecs_to_jiffies(200)); return 0; +free_slots: + kfree(pcr->slots); disable_irq: free_irq(pcr->irq, (void *)pcr); disable_msi: -- 2.25.1