From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32942C433E7 for ; Sun, 18 Oct 2020 19:36:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01B84207DE for ; Sun, 18 Oct 2020 19:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049814; bh=Pnubr0Y7tbf7TY7tl8kU9rlHL0BLmTKkFTHK9tnIR2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ynh7IZ6B+SDv1EmCANUHii0d7cTdygvXyPMaTLAGzlzw52TSQPpNiui6j2++o5PRv 4TAGJsrIPvZ1Xzh7lSacBWBkGOYZ140OUXDS6N4xfigyZ50b3WwgVFi89OwkydZnoI 6MhHeOMVty8luEQ1/vEmUmn9gau/RuWChAofZ1ns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732825AbgJRTgw (ORCPT ); Sun, 18 Oct 2020 15:36:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:41278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731594AbgJRT0M (ORCPT ); Sun, 18 Oct 2020 15:26:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F02B222E7; Sun, 18 Oct 2020 19:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603049172; bh=Pnubr0Y7tbf7TY7tl8kU9rlHL0BLmTKkFTHK9tnIR2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KcvKfZJQW0ueinmANz0HZWv7P2KdRjvV0ERc7AXTbPrdsNbMAEWCeDuFF+ClaP4XA 6XBEwAuJnTyimKvdKSkgP8Pp495UNYxmv0xhXkgThs9OiViw6xiuo/TbZ3Jt0PZgg2 ns40wXL+RFwt8Rs1cRxKVbxU7CclgQmZEe/fAMg4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Eric Biggers , syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com, Jan Kara , Sasha Levin , reiserfs-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 35/52] reiserfs: only call unlock_new_inode() if I_NEW Date: Sun, 18 Oct 2020 15:25:12 -0400 Message-Id: <20201018192530.4055730-35-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192530.4055730-1-sashal@kernel.org> References: <20201018192530.4055730-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers [ Upstream commit 8859bf2b1278d064a139e3031451524a49a56bd0 ] unlock_new_inode() is only meant to be called after a new inode has already been inserted into the hash table. But reiserfs_new_inode() can call it even before it has inserted the inode, triggering the WARNING in unlock_new_inode(). Fix this by only calling unlock_new_inode() if the inode has the I_NEW flag set, indicating that it's in the table. This addresses the syzbot report "WARNING in unlock_new_inode" (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7). Link: https://lore.kernel.org/r/20200628070057.820213-1-ebiggers@kernel.org Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com Signed-off-by: Eric Biggers Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/reiserfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index 683496322aa8b..e7d02058eb611 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c @@ -2164,7 +2164,8 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, out_inserted_sd: clear_nlink(inode); th->t_trans_id = 0; /* so the caller can't use this handle later */ - unlock_new_inode(inode); /* OK to do even if we hadn't locked it */ + if (inode->i_state & I_NEW) + unlock_new_inode(inode); iput(inode); return err; } -- 2.25.1