From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43503C433E7 for ; Sun, 18 Oct 2020 21:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DAA4222BA for ; Sun, 18 Oct 2020 21:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kapsi.fi header.i=@kapsi.fi header.b="yKMXhIWS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727840AbgJRVOc (ORCPT ); Sun, 18 Oct 2020 17:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbgJRVOb (ORCPT ); Sun, 18 Oct 2020 17:14:31 -0400 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B57C061755; Sun, 18 Oct 2020 14:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JntMkUcaE6m2axYjHJlpEVkT5Ke5knS/JE2R/iZ99pg=; b=yKMXhIWSdeSD7VBKfA2omx2RaP ipWzb5Zgqvx4nMnjkGRqUYU7pO/nR7QaaAXH5vDoqhmD0MPcrqIqxvlBAOCbKD90lhM7Dh6lfWs8K Qy0RoERft6mWWfG6z8bI0MWAN9dy3t6pbObmvir1zxyfyBqgkdjdgcgLRzka7DbE57co1XuDSo6dW DJETbf+JWegtetCNkitCngSzR2VWrxRKmD8Vu2Ba4pBXpdPgSJ0U0SKCwVfCoKMeM7hrx8rZ1qnf4 75Z6d0PQ2P54druh3gXQU2U91atwYwRYFgyzbUGkDkaNC7BAyCC6U39M9udWrlttxnBQ+mCONEbWM fwaU4GNg==; Received: from 83-245-197-237.elisa-laajakaista.fi ([83.245.197.237] helo=localhost) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1kUG0b-0002xD-8l; Mon, 19 Oct 2020 00:14:29 +0300 Date: Mon, 19 Oct 2020 00:14:28 +0300 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko@kernel.org, Peter Huewe , Jason Gunthorpe , Hans de Goede , James Bottomley Subject: Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s Message-ID: <20201018211428.GD575510@kapsi.fi> References: <20201015214430.17937-1-jsnitsel@redhat.com> <20201018211143.GC575510@kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201018211143.GC575510@kapsi.fi> X-SA-Exim-Connect-IP: 83.245.197.237 X-SA-Exim-Mail-From: jarkko.sakkinen@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2020 at 12:11:44AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 15, 2020 at 02:44:30PM -0700, Jerry Snitselaar wrote: > > There is a misconfiguration in the bios of the gpio pin used for the > > interrupt in the T490s. When interrupts are enabled in the tpm_tis > > driver code this results in an interrupt storm. This was initially > > reported when we attempted to enable the interrupt code in the tpm_tis > > driver, which previously wasn't setting a flag to enable it. Due to > > the reports of the interrupt storm that code was reverted and we went back > > to polling instead of using interrupts. Now that we know the T490s problem > > is a firmware issue, add code to check if the system is a T490s and > > disable interrupts if that is the case. This will allow us to enable > > interrupts for everyone else. If the user has a fixed bios they can > > force the enabling of interrupts with tpm_tis.interrupts=1 on the > > kernel command line. > > > > Cc: jarkko@kernel.org > > Cc: Peter Huewe > > Cc: Jason Gunthorpe > > Cc: Hans de Goede > > Reviewed-by: James Bottomley > > Signed-off-by: Jerry Snitselaar > > Reviewed-by: Jarkko Sakkinen > > I'll apply this and make it available in linux-next. Applied. Thank you. /Jarkko