From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE74C433E7 for ; Mon, 19 Oct 2020 13:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35D50222BA for ; Mon, 19 Oct 2020 13:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbgJSNuR (ORCPT ); Mon, 19 Oct 2020 09:50:17 -0400 Received: from mga18.intel.com ([134.134.136.126]:16870 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728277AbgJSNuQ (ORCPT ); Mon, 19 Oct 2020 09:50:16 -0400 IronPort-SDR: zROtJJ/qlHkLW+zbpT8SPUYgCMBYGM9NUL1MG51/B78xQzHGueQpeItNy9CubQzwpuylyk/ByP TZx5TG+06vUw== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="154820950" X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="154820950" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 06:50:15 -0700 IronPort-SDR: +pykw250Fmb+Dshcu2KrEc924MczhvYpVBiKHpy/hpTZKJrn9+57nDSjxRW0A/Hg+iWit9nTr5 gaWpYacS+kLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="422186200" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 19 Oct 2020 06:50:11 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 19 Oct 2020 16:50:10 +0300 Date: Mon, 19 Oct 2020 16:50:10 +0300 From: Heikki Krogerus To: Badhri Jagan Sridharan Cc: Guenter Roeck , Greg Kroah-Hartman , Rob Herring , Lee Jones , Mark Brown , Maxime Ripard , Alexandre Belloni , Thierry Reding , Prashant Malani , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Amelie Delaunay Subject: Re: [PATCH v10 15/15] usb: typec: tcpci_maxim: Enable auto discharge disconnect Message-ID: <20201019135010.GI1667571@kuha.fi.intel.com> References: <20201008061556.1402293-1-badhri@google.com> <20201008061556.1402293-16-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008061556.1402293-16-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 11:15:56PM -0700, Badhri Jagan Sridharan wrote: > Enable auto discharge disconnect for Maxim TCPC. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Heikki Krogerus > --- > Changes since v1: > - Changing patch version to v6 to fix version number confusion. > > Changes since v6: > - Rebase on usb-next. > > Changes since v7: > - Heikki's suggestion: > Moved the actual write of TCPC_VBUS_SINK_DISCONNECT_THRES > register to tcpci code. > > Changes since v8: > - Moved the logic to program the default values of > TCPC_VBUS_SINK_DISCONNECT_THRESH into the tcpci code. > > Changes since v9: > - none. > --- > drivers/usb/typec/tcpm/tcpci_maxim.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c > index 43dcad95e897..55dea33387ec 100644 > --- a/drivers/usb/typec/tcpm/tcpci_maxim.c > +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c > @@ -441,6 +441,7 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id > chip->data.TX_BUF_BYTE_x_hidden = true; > chip->data.init = tcpci_init; > chip->data.frs_sourcing_vbus = max_tcpci_frs_sourcing_vbus; > + chip->data.auto_discharge_disconnect = true; > > max_tcpci_init_regs(chip); > chip->tcpci = tcpci_register_port(chip->dev, &chip->data); > -- > 2.28.0.806.g8561365e88-goog -- heikki