From: Jiri Olsa <jolsa@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
Joe Mario <jmario@redhat.com>, David Ahern <dsahern@gmail.com>,
Don Zickus <dzickus@redhat.com>, Al Grant <Al.Grant@arm.com>,
James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 8/8] perf c2c: Update documentation for display option 'llc'
Date: Tue, 20 Oct 2020 09:26:57 +0200 [thread overview]
Message-ID: <20201020072657.GE2084117@krava> (raw)
In-Reply-To: <20201015145041.10953-9-leo.yan@linaro.org>
On Thu, Oct 15, 2020 at 03:50:41PM +0100, Leo Yan wrote:
> Since the new display option 'llc' is introduced, this patch is to
> update the documentation to reflect it.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/Documentation/perf-c2c.txt | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
> index c81d72e3eecf..eadce62ecd28 100644
> --- a/tools/perf/Documentation/perf-c2c.txt
> +++ b/tools/perf/Documentation/perf-c2c.txt
> @@ -109,7 +109,8 @@ REPORT OPTIONS
>
> -d::
> --display::
> - Switch to HITM type (rmt, lcl) to display and sort on. Total HITMs as default.
> + Switch to HITM type (rmt, lcl) or LLC load access (llc) to display
> + and sort on. Total HITMs as default.
ok, forget the doc update I asked in previous reply ;-)
thanks,
jirka
>
> --stitch-lbr::
> Show callgraph with stitched LBRs, which may have more complete
> @@ -174,12 +175,18 @@ For each cacheline in the 1) list we display following data:
> Cacheline
> - cacheline address (hex number)
>
> - Rmt/Lcl Hitm
> + Rmt/Lcl Hitm (For display with HITM types)
> - cacheline percentage of all Remote/Local HITM accesses
>
> - LLC Load Hitm - Total, LclHitm, RmtHitm
> + LLC Load Hitm - Total, LclHitm, RmtHitm (For display with HITM types)
> - count of Total/Local/Remote load HITMs
>
> + LLC Hit Pct (For display 'llc')
> + - cacheline percentage of all LLC load accesses
> +
> + LLC Hit Total (For display 'llc')
> + - sum of all LLC load accesses
> +
> Total records
> - sum of all cachelines accesses
>
> @@ -207,9 +214,12 @@ For each cacheline in the 1) list we display following data:
>
> For each offset in the 2) list we display following data:
>
> - HITM - Rmt, Lcl
> + HITM - Rmt, Lcl (For display with HITM types)
> - % of Remote/Local HITM accesses for given offset within cacheline
>
> + LLC LD - LclHit, LclHitm (For display 'llc')
> + - % of LLC hits and LLC HITMs accesses for given offset within cacheline
> +
> Store Refs - L1 Hit, L1 Miss
> - % of store accesses that hit/missed L1 for given offset within cacheline
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-20 7:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:50 [PATCH v1 0/8] perf c2c: Sort cacheline with LLC load Leo Yan
2020-10-15 14:50 ` [PATCH v1 1/8] perf mem: Add structure field c2c_stats::tot_llchit Leo Yan
2020-10-15 14:50 ` [PATCH v1 2/8] perf c2c: Add dimensions for total LLC hit Leo Yan
2020-10-15 14:50 ` [PATCH v1 3/8] perf c2c: Add dimensions for LLC load hit Leo Yan
2020-10-15 14:50 ` [PATCH v1 4/8] perf c2c: Change to general naming for macros Leo Yan
2020-10-15 14:50 ` [PATCH v1 5/8] perf c2c: Rename for shared cache line stats Leo Yan
2020-10-15 14:50 ` [PATCH v1 6/8] perf c2c: Refactor hist entry validation Leo Yan
2020-10-15 14:50 ` [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load Leo Yan
2020-10-20 7:25 ` Jiri Olsa
2020-10-20 8:08 ` Leo Yan
2020-10-22 8:43 ` Jiri Olsa
2020-10-20 7:26 ` Jiri Olsa
2020-10-20 8:14 ` Leo Yan
2020-10-15 14:50 ` [PATCH v1 8/8] perf c2c: Update documentation for display option 'llc' Leo Yan
2020-10-20 7:26 ` Jiri Olsa [this message]
2020-10-15 15:05 ` [PATCH v1 0/8] perf c2c: Sort cacheline with LLC load Arnaldo Carvalho de Melo
2020-10-15 15:14 ` Leo Yan
2020-10-20 8:13 ` Namhyung Kim
2020-10-20 8:18 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020072657.GE2084117@krava \
--to=jolsa@redhat.com \
--cc=Al.Grant@arm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jmario@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox