From: Daniel Vetter <daniel@ffwll.ch>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
Akhil P Oommen <akhilpo@codeaurora.org>,
Tanmay Shah <tanmay@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Emil Velikov <emil.velikov@collabora.com>,
Rob Clark <robdclark@chromium.org>,
Jonathan Marek <jonathan@marek.ca>,
Qinglang Miao <miaoqinglang@huawei.com>,
Roy Spliet <nouveau@spliet.org>,
Wambui Karuga <wambui.karugax@gmail.com>,
linux-arm-msm@vger.kernel.org,
Sharat Masetty <smasetty@codeaurora.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
tongtiangen <tongtiangen@huawei.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Drew Davenport <ddavenport@chromium.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] drm/msm: kthread_worker conversion
Date: Tue, 20 Oct 2020 10:24:04 +0200 [thread overview]
Message-ID: <20201020082404.GJ401619@phenom.ffwll.local> (raw)
In-Reply-To: <20201019211101.143327-1-robdclark@gmail.com>
On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> In particular, converting the async atomic commit (for cursor updates,
> etc) to SCHED_FIFO kthread_worker helps with some cases where we
> wouldn't manage to flush the updates within the 1ms-before-vblank
> deadline resulting in fps drops when there is cursor movement.
>
> Rob Clark (3):
> drm/msm/gpu: Convert retire/recover work to kthread_worker
> drm/msm/kms: Update msm_kms_init/destroy
> drm/msm/atomic: Convert to per-CRTC kthread_work
So i915 has it's own commit worker already for $reasons, but I don't think
that's a good path to go down with more drivers. And the problem seems
entirely generic in nature ...
-Daniel
>
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +--
> drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 6 ++---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +--
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 +++++-
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 8 +++++-
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 ++++++---
> drivers/gpu/drm/msm/disp/mdp_kms.h | 9 +++++--
> drivers/gpu/drm/msm/msm_atomic.c | 25 +++++++++++++++----
> drivers/gpu/drm/msm/msm_drv.h | 3 ++-
> drivers/gpu/drm/msm/msm_gpu.c | 30 +++++++++++++++--------
> drivers/gpu/drm/msm/msm_gpu.h | 13 +++++++---
> drivers/gpu/drm/msm/msm_kms.h | 23 ++++++++++++++---
> 13 files changed, 104 insertions(+), 43 deletions(-)
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-10-20 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:10 [PATCH 0/3] drm/msm: kthread_worker conversion Rob Clark
2020-10-19 21:10 ` [PATCH 1/3] drm/msm/gpu: Convert retire/recover work to kthread_worker Rob Clark
2020-10-19 21:10 ` [PATCH 2/3] drm/msm/kms: Update msm_kms_init/destroy Rob Clark
2020-10-19 21:10 ` [PATCH 3/3] drm/msm/atomic: Convert to per-CRTC kthread_work Rob Clark
2020-10-20 8:24 ` Daniel Vetter [this message]
2020-10-20 14:00 ` [PATCH 0/3] drm/msm: kthread_worker conversion Rob Clark
2020-10-20 14:29 ` Daniel Vetter
2020-10-20 15:08 ` Rob Clark
2020-10-20 17:02 ` Daniel Vetter
2020-10-20 17:23 ` Rob Clark
2020-10-20 18:14 ` Daniel Vetter
2020-10-20 20:26 ` Rob Clark
2020-10-21 8:26 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020082404.GJ401619@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akhilpo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=ddavenport@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=freedreno@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=jonathan@marek.ca \
--cc=kalyan_t@codeaurora.org \
--cc=kholk11@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=nouveau@spliet.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sam@ravnborg.org \
--cc=smasetty@codeaurora.org \
--cc=tanmay@codeaurora.org \
--cc=tongtiangen@huawei.com \
--cc=tzimmermann@suse.de \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox