From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3C1C4363A for ; Wed, 21 Oct 2020 10:30:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 537D722251 for ; Wed, 21 Oct 2020 10:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441766AbgJUKaN (ORCPT ); Wed, 21 Oct 2020 06:30:13 -0400 Received: from foss.arm.com ([217.140.110.172]:33236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410020AbgJUKaM (ORCPT ); Wed, 21 Oct 2020 06:30:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F306A1FB; Wed, 21 Oct 2020 03:30:11 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 526433F66E; Wed, 21 Oct 2020 03:30:10 -0700 (PDT) Date: Wed, 21 Oct 2020 11:30:08 +0100 From: Cristian Marussi To: Thara Gopinath Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization Message-ID: <20201021103008.GC20482@e120937-lin> References: <20201014150545.44807-1-cristian.marussi@arm.com> <20201014150545.44807-7-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2020 at 10:47:28PM -0400, Thara Gopinath wrote: > > > On 10/14/20 11:05 AM, Cristian Marussi wrote: > > Modify protocol initialization callback adding a new parameter representing > > a reference to the available xfer core operations and introduce a macro to > > simply register with the core new protocols as loadable drivers. > > Keep standard protocols as builtin. > > > > Signed-off-by: Cristian Marussi > > --- > > drivers/firmware/arm_scmi/base.c | 56 ++++++++++-------- > > drivers/firmware/arm_scmi/bus.c | 14 ++++- > > drivers/firmware/arm_scmi/clock.c | 56 +++++++++--------- > > drivers/firmware/arm_scmi/common.h | 42 +++++++++----- > > drivers/firmware/arm_scmi/driver.c | 50 ++++++++++------ > > drivers/firmware/arm_scmi/perf.c | 88 +++++++++++++++-------------- > > drivers/firmware/arm_scmi/power.c | 46 ++++++++------- > > drivers/firmware/arm_scmi/reset.c | 46 ++++++++------- > > drivers/firmware/arm_scmi/sensors.c | 52 +++++++++-------- > > drivers/firmware/arm_scmi/system.c | 16 ++++-- > > include/linux/scmi_protocol.h | 18 +++++- > > 11 files changed, 288 insertions(+), 196 deletions(-) > > > > diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c > > index f40821eeb103..8d7214fd2187 100644 > > --- a/drivers/firmware/arm_scmi/base.c > > +++ b/drivers/firmware/arm_scmi/base.c > > @@ -15,6 +15,8 @@ > > #define SCMI_BASE_NUM_SOURCES 1 > > #define SCMI_BASE_MAX_CMD_ERR_COUNT 1024 > > +static const struct scmi_xfer_ops *ops; > > Minor nit. I would consider renaming ops to something more > meaningful like xfer_ops (or anything that makes sense). ops by > itself leads to confusion with ops in scmo_protocol and in > scmi_protocol_events. > > Same suggestion for all other declarations of ops in this patch. > I agree, but I'm in fact reworking deeply the interface for protocols initialization (following some idea from Florian) in order to pass down a protocol object including the xfer_ops instead of a handle+ops like now, so this hopefully will solve also this concern. Thanks Cristian > -- > Warm Regards > Thara