From: kernel test robot <lkp@intel.com>
To: Furquan Shaikh <furquan@google.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Prashant Malani <pmalani@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arthur Heymans <arthur@aheymans.xyz>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Ard Biesheuvel <ardb@kernel.org>,
dlaurie@google.com, Furquan Shaikh <furquan@google.com>
Subject: Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions
Date: Wed, 21 Oct 2020 15:52:01 +0800 [thread overview]
Message-ID: <202010211512.fRqGIqAI-lkp@intel.com> (raw)
In-Reply-To: <20201021050141.377787-1-furquan@google.com>
[-- Attachment #1: Type: text/plain, Size: 2683 bytes --]
Hi Furquan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.9 next-20201021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Furquan-Shaikh/firmware-gsmi-Drop-the-use-of-dma_pool_-API-functions/20201021-130247
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c4d6fe7311762f2e03b3c27ad38df7c40c80cc93
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/66886f5e6d40e829b8a48ab2dbb6615b906290a5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Furquan-Shaikh/firmware-gsmi-Drop-the-use-of-dma_pool_-API-functions/20201021-130247
git checkout 66886f5e6d40e829b8a48ab2dbb6615b906290a5
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/firmware/google/gsmi.c: In function 'gsmi_page_alloc':
>> drivers/firmware/google/gsmi.c:170:6: warning: right shift count >= width of type [-Wshift-count-overflow]
170 | >> 32) {
| ^~
vim +170 drivers/firmware/google/gsmi.c
151
152 static struct gsmi_page *gsmi_page_alloc(void)
153 {
154 struct gsmi_page *page_info;
155
156 page_info = kzalloc(sizeof(*page_info), GFP_KERNEL);
157 if (!page_info) {
158 printk(KERN_ERR "gsmi: out of memory\n");
159 return NULL;
160 }
161
162 page_info->base_address = get_zeroed_page(GFP_KERNEL | GFP_DMA32);
163 if (!page_info->base_address) {
164 printk(KERN_ERR "gsmi: failed to allocate page for buffers\n");
165 return NULL;
166 }
167
168 /* Ensure the entire buffer is allocated within 32bit address space */
169 if (virt_to_phys((void *)(page_info->base_address + PAGE_SIZE - 1))
> 170 >> 32) {
171 printk(KERN_ERR "gsmi: allocation not within 32-bit physical address space\n");
172 free_page(page_info->base_address);
173 kfree(page_info);
174 return NULL;
175 }
176
177 page_info->alloc_size = PAGE_SIZE;
178
179 return page_info;
180 }
181
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75632 bytes --]
prev parent reply other threads:[~2020-10-21 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 5:01 [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions Furquan Shaikh
2020-10-21 5:19 ` Greg Kroah-Hartman
2020-10-21 6:37 ` Ard Biesheuvel
2020-10-21 7:37 ` Furquan Shaikh
2020-10-21 8:52 ` Greg Kroah-Hartman
2020-10-21 9:36 ` Ard Biesheuvel
2020-10-21 21:46 ` Furquan Shaikh
2020-10-22 4:38 ` [PATCH v2] " Furquan Shaikh
2020-10-22 7:02 ` Ard Biesheuvel
2020-10-22 7:15 ` [PATCH v3] " Furquan Shaikh
2020-10-21 7:52 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010211512.fRqGIqAI-lkp@intel.com \
--to=lkp@intel.com \
--cc=ardb@kernel.org \
--cc=arthur@aheymans.xyz \
--cc=dlaurie@google.com \
--cc=furquan@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox