* [PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig
@ 2020-10-22 2:12 Chen Jun
2020-10-22 9:34 ` Catalin Marinas
2021-03-18 14:51 ` [RESEND PATCH] " chenjun (AM)
0 siblings, 2 replies; 4+ messages in thread
From: Chen Jun @ 2020-10-22 2:12 UTC (permalink / raw)
To: linux-kernel; +Cc: catalin.marinas, rui.xiang, weiyongjun1, guohanjun
From: Chen Jun <c00424029@huawei.com>
commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a
("mm,kmemleak-test.c: move kmemleak-test.c to samples dir")
make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly.
And the dependency cannot be guaranteed by Kconfig.
move the definition of CONFIG_DEBUG_KMEMLEAK_TEST from lib/Kconfig.debug
to samples/Kconfig.
Signed-off-by: Chen Jun <c00424029@huawei.com>
---
lib/Kconfig.debug | 8 --------
samples/Kconfig | 8 ++++++++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 66d44d3..debacdc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -678,14 +678,6 @@ config DEBUG_KMEMLEAK_MEM_POOL_SIZE
fully initialised, this memory pool acts as an emergency one
if slab allocations fail.
-config DEBUG_KMEMLEAK_TEST
- tristate "Simple test for the kernel memory leak detector"
- depends on DEBUG_KMEMLEAK && m
- help
- This option enables a module that explicitly leaks memory.
-
- If unsure, say N.
-
config DEBUG_KMEMLEAK_DEFAULT_OFF
bool "Default kmemleak to off"
depends on DEBUG_KMEMLEAK
diff --git a/samples/Kconfig b/samples/Kconfig
index 0ed6e4d..15978dd 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -216,4 +216,12 @@ config SAMPLE_WATCH_QUEUE
Build example userspace program to use the new mount_notify(),
sb_notify() syscalls and the KEYCTL_WATCH_KEY keyctl() function.
+config DEBUG_KMEMLEAK_TEST
+ tristate "Simple test for the kernel memory leak detector"
+ depends on DEBUG_KMEMLEAK && m
+ help
+ This option enables a module that explicitly leaks memory.
+
+ If unsure, say N.
+
endif # SAMPLES
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig
2020-10-22 2:12 [PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig Chen Jun
@ 2020-10-22 9:34 ` Catalin Marinas
2021-03-18 14:51 ` [RESEND PATCH] " chenjun (AM)
1 sibling, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2020-10-22 9:34 UTC (permalink / raw)
To: Chen Jun; +Cc: linux-kernel, rui.xiang, weiyongjun1, guohanjun
On Thu, Oct 22, 2020 at 02:12:34AM +0000, Chen Jun wrote:
> From: Chen Jun <c00424029@huawei.com>
>
> commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a
> ("mm,kmemleak-test.c: move kmemleak-test.c to samples dir")
> make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly.
> And the dependency cannot be guaranteed by Kconfig.
>
> move the definition of CONFIG_DEBUG_KMEMLEAK_TEST from lib/Kconfig.debug
> to samples/Kconfig.
>
> Signed-off-by: Chen Jun <c00424029@huawei.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [RESEND PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig
2020-10-22 2:12 [PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig Chen Jun
2020-10-22 9:34 ` Catalin Marinas
@ 2021-03-18 14:51 ` chenjun (AM)
2021-03-19 17:56 ` Catalin Marinas
1 sibling, 1 reply; 4+ messages in thread
From: chenjun (AM) @ 2021-03-18 14:51 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org
Cc: catalin.marinas@arm.com, Xiangrui (Euler), weiyongjun (A),
Guohanjun (Hanjun Guo)
From: Chen Jun <chenjun102@huawei.com>
commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a
("mm,kmemleak-test.c: move kmemleak-test.c to samples dir")
make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly.
And the dependency cannot be guaranteed by Kconfig.
move the definition of CONFIG_DEBUG_KMEMLEAK_TEST from lib/Kconfig.debug
to samples/Kconfig.
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
---
lib/Kconfig.debug | 8 --------
samples/Kconfig | 8 ++++++++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 66d44d3..debacdc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -678,14 +678,6 @@ config DEBUG_KMEMLEAK_MEM_POOL_SIZE
fully initialised, this memory pool acts as an emergency one
if slab allocations fail.
-config DEBUG_KMEMLEAK_TEST
- tristate "Simple test for the kernel memory leak detector"
- depends on DEBUG_KMEMLEAK && m
- help
- This option enables a module that explicitly leaks memory.
-
- If unsure, say N.
-
config DEBUG_KMEMLEAK_DEFAULT_OFF
bool "Default kmemleak to off"
depends on DEBUG_KMEMLEAK
diff --git a/samples/Kconfig b/samples/Kconfig
index 0ed6e4d..15978dd 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -216,4 +216,12 @@ config SAMPLE_WATCH_QUEUE
Build example userspace program to use the new mount_notify(),
sb_notify() syscalls and the KEYCTL_WATCH_KEY keyctl() function.
+config DEBUG_KMEMLEAK_TEST
+ tristate "Simple test for the kernel memory leak detector"
+ depends on DEBUG_KMEMLEAK && m
+ help
+ This option enables a module that explicitly leaks memory.
+
+ If unsure, say N.
+
endif # SAMPLES
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [RESEND PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig
2021-03-18 14:51 ` [RESEND PATCH] " chenjun (AM)
@ 2021-03-19 17:56 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-03-19 17:56 UTC (permalink / raw)
To: chenjun (AM)
Cc: linux-kernel@vger.kernel.org, Xiangrui (Euler), weiyongjun (A),
Guohanjun (Hanjun Guo), Andrew Morton
On Thu, Mar 18, 2021 at 02:51:07PM +0000, chenjun (AM) wrote:
> From: Chen Jun <chenjun102@huawei.com>
>
> commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a
> ("mm,kmemleak-test.c: move kmemleak-test.c to samples dir")
> make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly.
> And the dependency cannot be guaranteed by Kconfig.
>
> move the definition of CONFIG_DEBUG_KMEMLEAK_TEST from lib/Kconfig.debug
> to samples/Kconfig.
>
> Signed-off-by: Chen Jun <chenjun102@huawei.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc'ing Andrew, I don't think he's seen the patch.
> lib/Kconfig.debug | 8 --------
> samples/Kconfig | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 66d44d3..debacdc 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -678,14 +678,6 @@ config DEBUG_KMEMLEAK_MEM_POOL_SIZE
> fully initialised, this memory pool acts as an emergency one
> if slab allocations fail.
>
> -config DEBUG_KMEMLEAK_TEST
> - tristate "Simple test for the kernel memory leak detector"
> - depends on DEBUG_KMEMLEAK && m
> - help
> - This option enables a module that explicitly leaks memory.
> -
> - If unsure, say N.
> -
> config DEBUG_KMEMLEAK_DEFAULT_OFF
> bool "Default kmemleak to off"
> depends on DEBUG_KMEMLEAK
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 0ed6e4d..15978dd 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -216,4 +216,12 @@ config SAMPLE_WATCH_QUEUE
> Build example userspace program to use the new mount_notify(),
> sb_notify() syscalls and the KEYCTL_WATCH_KEY keyctl() function.
>
> +config DEBUG_KMEMLEAK_TEST
> + tristate "Simple test for the kernel memory leak detector"
> + depends on DEBUG_KMEMLEAK && m
> + help
> + This option enables a module that explicitly leaks memory.
> +
> + If unsure, say N.
> +
> endif # SAMPLES
> --
> 2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-19 17:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-22 2:12 [PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig Chen Jun
2020-10-22 9:34 ` Catalin Marinas
2021-03-18 14:51 ` [RESEND PATCH] " chenjun (AM)
2021-03-19 17:56 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox