From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 4/5] xen/events: unmask a fifo event channel only if it was masked
Date: Thu, 22 Oct 2020 11:49:06 +0200 [thread overview]
Message-ID: <20201022094907.28560-5-jgross@suse.com> (raw)
In-Reply-To: <20201022094907.28560-1-jgross@suse.com>
Unmasking an event channel with fifo events channels being used can
require a hypercall to be made, so try to avoid that by checking
whether the event channel was really masked.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- move test for already unmasked into loop (Jan Beulich)
---
drivers/xen/events/events_fifo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
index 243e7b6d7b96..b234f1766810 100644
--- a/drivers/xen/events/events_fifo.c
+++ b/drivers/xen/events/events_fifo.c
@@ -237,6 +237,9 @@ static bool clear_masked_cond(volatile event_word_t *word)
w = *word;
do {
+ if (!(w & (1 << EVTCHN_FIFO_MASKED)))
+ return true;
+
if (w & (1 << EVTCHN_FIFO_PENDING))
return false;
--
2.26.2
next prev parent reply other threads:[~2020-10-22 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 9:49 [PATCH v2 0/5] xen: event handling cleanup Juergen Gross
2020-10-22 9:49 ` [PATCH v2 1/5] xen: remove no longer used functions Juergen Gross
2020-10-22 9:49 ` [PATCH v2 2/5] xen/events: make struct irq_info private to events_base.c Juergen Gross
2020-10-22 9:49 ` [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events Juergen Gross
2020-10-22 10:35 ` Jan Beulich
2020-10-22 13:09 ` Jürgen Groß
2020-10-22 13:17 ` Jan Beulich
2020-10-22 9:49 ` Juergen Gross [this message]
2020-10-22 9:49 ` [PATCH v2 5/5] Documentation: add xen.fifo_events kernel parameter description Juergen Gross
2020-10-23 13:37 ` [PATCH v2 0/5] xen: event handling cleanup boris.ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022094907.28560-5-jgross@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox