From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scs: switch to vmapped shadow stacks
Date: Thu, 22 Oct 2020 15:38:41 -0700 [thread overview]
Message-ID: <202010221538.9FA560D5B0@keescook> (raw)
In-Reply-To: <20201022202355.3529836-2-samitolvanen@google.com>
On Thu, Oct 22, 2020 at 01:23:54PM -0700, Sami Tolvanen wrote:
> The kernel currently uses kmem_cache to allocate shadow call stacks,
> which means an overflow may not be immediately detected and can
> potentially result in another task's shadow stack to be overwritten.
>
> This change switches SCS to use virtually mapped shadow stacks,
> which increases shadow stack size to a full page and provides more
> robust overflow detection similarly to VMAP_STACK.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Thanks! I much prefer this to kmem. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-10-22 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 20:23 [PATCH 0/2] scs: switch to vmapped shadow stacks Sami Tolvanen
2020-10-22 20:23 ` [PATCH 1/2] " Sami Tolvanen
2020-10-22 22:38 ` Kees Cook [this message]
2020-11-19 13:00 ` Will Deacon
2020-11-20 17:00 ` Sami Tolvanen
2020-11-23 11:08 ` Will Deacon
2020-10-22 20:23 ` [PATCH 2/2] arm64: scs: use vmapped IRQ and SDEI " Sami Tolvanen
2020-10-22 22:38 ` Kees Cook
2020-11-19 13:11 ` Will Deacon
2020-11-17 17:35 ` [PATCH 0/2] scs: switch to vmapped " Catalin Marinas
2020-11-18 9:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010221538.9FA560D5B0@keescook \
--to=keescook@chromium.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox