Re: [PATCH 07/10] x86/entry: Pass irqentry_state_t by reference

Thomas Gleixner
2020-10-23T21:56:37Z

On Thu, Oct 22 2020 at 15:26, ira weiny wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> In preparation for adding PKS information to struct irqentry_state_t
> change all call sites and usages to pass the struct by reference
> instead of by value.

This still does not explain WHY you need to do that. 'Preparation' is a
pretty useless information.

What is the actual reason for this? Just because PKS information feels
better that way?

Also what is PKS information? Changelogs have to make sense on their own
and not only in the context of a larger series of changes.

> While we are editing the call sites it is a good time to standardize on
> the name 'irq_state'.

While at it change all usage sites to consistently use the variable
name 'irq_state'.

Or something like that. See Documentation/process/...

Thanks,

tglx