From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EAFC5517A for ; Fri, 23 Oct 2020 13:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9628320EDD for ; Fri, 23 Oct 2020 13:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S465047AbgJWNf0 (ORCPT ); Fri, 23 Oct 2020 09:35:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:46528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgJWNf0 (ORCPT ); Fri, 23 Oct 2020 09:35:26 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61CEE208E4; Fri, 23 Oct 2020 13:35:25 +0000 (UTC) Date: Fri, 23 Oct 2020 09:35:23 -0400 From: Steven Rostedt To: Alexander Gordeev Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner , Masami Hiramatsu Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers Message-ID: <20201023093523.65c495f8@gandalf.local.home> In-Reply-To: <1603443123-17457-1-git-send-email-agordeev@linux.ibm.com> References: <1603443123-17457-1-git-send-email-agordeev@linux.ibm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Oct 2020 10:52:03 +0200 Alexander Gordeev wrote: > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > index acb17ce..0ddb948 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > @@ -39,7 +39,7 @@ do_test() { > disable_tracing > > echo do_execve* > set_ftrace_filter > - echo *do_fork >> set_ftrace_filter > + echo kernel_clone >> set_ftrace_filter > > echo $PID > set_ftrace_notrace_pid > echo function > current_tracer > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > index 9f0a968..71319b3 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > @@ -39,7 +39,7 @@ do_test() { > disable_tracing > > echo do_execve* > set_ftrace_filter > - echo *do_fork >> set_ftrace_filter > + echo kernel_clone >> set_ftrace_filter > > echo $PID > set_ftrace_pid > echo function > current_tracer The issue I have with this, is that I run these tests on older kernels too, and tests that use to work on older kernels should still work. In fact, this fails on the kernel I'm currently adding new changes to! Perhaps we should have: # older kernels have do_fork, but newer kernels have kernel_clone echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter The above still seems to work for me. -- Steve