Re: [PATCH] kernel-doc: validate function prototype names

kernel test robot
2020-10-23T10:19:29Z

[-- Attachment #1: Type: text/plain, Size: 5819 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/kernel-doc-validate-function-prototype-names/20201023-153539
base: git://git.lwn.net/linux-2.6 docs-next
config: i386-randconfig-a005-20201023 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/5193d879fdb280898c28b196d3177b61d48fd2db
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/kernel-doc-validate-function-prototype-names/20201023-153539
git checkout 5193d879fdb280898c28b196d3177b61d48fd2db
# save the attached .config to linux build tree
make W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/mei/hw-me.c:1394: warning: expecting prototype for function mei_me_fw_sku_sps_4. Prototype was for function mei_me_fw_type_sps_4 instead
>> drivers/misc/mei/hw-me.c:1418: warning: expecting prototype for function mei_me_fw_sku_sps. Prototype was for function mei_me_fw_type_sps instead

vim +1394 drivers/misc/mei/hw-me.c

c919951d940f28b Tomas Winkler 2014-05-13 1378
c919951d940f28b Tomas Winkler 2014-05-13 1379 #define MEI_CFG_FW_NM \
c919951d940f28b Tomas Winkler 2014-05-13 1380 .quirk_probe = mei_me_fw_type_nm
c919951d940f28b Tomas Winkler 2014-05-13 1381
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1382 /**
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1383 * mei_me_fw_sku_sps_4() - check for sps 4.0 sku
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1384 *
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1385 * Read ME FW Status register to check for SPS Firmware.
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1386 * The SPS FW is only signaled in the PCI function 0.
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1387 * __Note__: Deprecated by SPS 5.0 and newer.
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1388 *
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1389 * @pdev: pci device
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1390 *
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1391 * Return: true in case of SPS firmware
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1392 */
45a2c76283ace79 Tomas Winkler 2020-06-19 1393 static bool mei_me_fw_type_sps_4(const struct pci_dev *pdev)
c919951d940f28b Tomas Winkler 2014-05-13 @1394 {
c919951d940f28b Tomas Winkler 2014-05-13 1395 u32 reg;
8c57cac1457f312 Tomas Winkler 2016-07-20 1396 unsigned int devfn;
8c57cac1457f312 Tomas Winkler 2016-07-20 1397
8c57cac1457f312 Tomas Winkler 2016-07-20 1398 devfn = PCI_DEVFN(PCI_SLOT(pdev->devfn), 0);
8c57cac1457f312 Tomas Winkler 2016-07-20 1399 pci_bus_read_config_dword(pdev->bus, devfn, PCI_CFG_HFS_1, &reg);
a96c548291719ae Tomas Winkler 2016-02-07 1400 trace_mei_pci_cfg_read(&pdev->dev, "PCI_CFG_HFS_1", PCI_CFG_HFS_1, reg);
4d3c6c8eb9816a0 Tomas Winkler 2020-06-19 1401 return (reg & PCI_CFG_HFS_1_OPMODE_MSK) == PCI_CFG_HFS_1_OPMODE_SPS;
c919951d940f28b Tomas Winkler 2014-05-13 1402 }
c919951d940f28b Tomas Winkler 2014-05-13 1403
f76d77f50b343bc Tomas Winkler 2020-06-19 1404 #define MEI_CFG_FW_SPS_4 \
f76d77f50b343bc Tomas Winkler 2020-06-19 1405 .quirk_probe = mei_me_fw_type_sps_4
f76d77f50b343bc Tomas Winkler 2020-06-19 1406
f76d77f50b343bc Tomas Winkler 2020-06-19 1407 /**
f76d77f50b343bc Tomas Winkler 2020-06-19 1408 * mei_me_fw_sku_sps() - check for sps sku
f76d77f50b343bc Tomas Winkler 2020-06-19 1409 *
f76d77f50b343bc Tomas Winkler 2020-06-19 1410 * Read ME FW Status register to check for SPS Firmware.
f76d77f50b343bc Tomas Winkler 2020-06-19 1411 * The SPS FW is only signaled in pci function 0
f76d77f50b343bc Tomas Winkler 2020-06-19 1412 *
f76d77f50b343bc Tomas Winkler 2020-06-19 1413 * @pdev: pci device
f76d77f50b343bc Tomas Winkler 2020-06-19 1414 *
f76d77f50b343bc Tomas Winkler 2020-06-19 1415 * Return: true in case of SPS firmware
f76d77f50b343bc Tomas Winkler 2020-06-19 1416 */
45a2c76283ace79 Tomas Winkler 2020-06-19 1417 static bool mei_me_fw_type_sps(const struct pci_dev *pdev)
f76d77f50b343bc Tomas Winkler 2020-06-19 @1418 {
f76d77f50b343bc Tomas Winkler 2020-06-19 1419 u32 reg;
f76d77f50b343bc Tomas Winkler 2020-06-19 1420 u32 fw_type;
f76d77f50b343bc Tomas Winkler 2020-06-19 1421 unsigned int devfn;
f76d77f50b343bc Tomas Winkler 2020-06-19 1422
f76d77f50b343bc Tomas Winkler 2020-06-19 1423 devfn = PCI_DEVFN(PCI_SLOT(pdev->devfn), 0);
f76d77f50b343bc Tomas Winkler 2020-06-19 1424 pci_bus_read_config_dword(pdev->bus, devfn, PCI_CFG_HFS_3, &reg);
f76d77f50b343bc Tomas Winkler 2020-06-19 1425 trace_mei_pci_cfg_read(&pdev->dev, "PCI_CFG_HFS_3", PCI_CFG_HFS_3, reg);
f76d77f50b343bc Tomas Winkler 2020-06-19 1426 fw_type = (reg & PCI_CFG_HFS_3_FW_SKU_MSK);
f76d77f50b343bc Tomas Winkler 2020-06-19 1427
f76d77f50b343bc Tomas Winkler 2020-06-19 1428 dev_dbg(&pdev->dev, "fw type is %d\n", fw_type);
f76d77f50b343bc Tomas Winkler 2020-06-19 1429
f76d77f50b343bc Tomas Winkler 2020-06-19 1430 return fw_type == PCI_CFG_HFS_3_FW_SKU_SPS;
f76d77f50b343bc Tomas Winkler 2020-06-19 1431 }
f76d77f50b343bc Tomas Winkler 2020-06-19 1432

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29635 bytes --]