From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: zhenwei pi <pizhenwei@bytedance.com>,
kbusch@kernel.org, hch@lst.de, axboe@fb.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme-rdma: handle nvme completion data length
Date: Sat, 24 Oct 2020 09:36:21 +0200 [thread overview]
Message-ID: <20201024073621.GA28151@lst.de> (raw)
In-Reply-To: <d23e33e7-d545-2ad0-d163-5182dd5430b1@grimberg.me>
On Fri, Oct 23, 2020 at 11:01:40AM -0700, Sagi Grimberg wrote:
>> + /* received data length checking */
>> + if (unlikely(wc->byte_len < len)) {
>> + /* zero bytes message could be ignored */
>> + if (!wc->byte_len) {
>> + nvme_rdma_post_recv(queue, qe);
>> + return;
>> + }
>
> Nothing in the spec defines zero-length messages, hence we cannot
> support something that is not standard. If your array needs this,
> please submit a TPAR to the NVMe TWG.
We'll still need sanity checking instead of the recount underflow,
I think tearing down the connection here and kicking off error recovery
is probably the best idea.
prev parent reply other threads:[~2020-10-24 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 6:59 [PATCH v2] nvme-rdma: handle nvme completion data length zhenwei pi
2020-10-23 8:45 ` Chao Leng
2020-10-23 18:01 ` Sagi Grimberg
2020-10-24 7:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201024073621.GA28151@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pizhenwei@bytedance.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox