From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9FCC55178 for ; Sat, 24 Oct 2020 08:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB94322460 for ; Sat, 24 Oct 2020 08:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NDRtxukW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759975AbgJXIAW (ORCPT ); Sat, 24 Oct 2020 04:00:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756271AbgJXIAV (ORCPT ); Sat, 24 Oct 2020 04:00:21 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71823C0613CE for ; Sat, 24 Oct 2020 01:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VtJ3/QfVYCJIzUimUHreYja6C5qKjpi3sBKHDNwKYcQ=; b=NDRtxukWe2cUfgssnc00+8lYub c2FX/x0Fp5aJvCnK31DdXCOXqDa3h6sD8kRe6OazFO8t3gu2FtKihT3ObNVUTell7gI0rHMLcENOC dpQcYl80m71lYTgNFJhq6hGdctXDMmzjlAfSsEhKTlEOUhSQkdmKgrf+ktLwET+3kmPF7DGDSelar 40ywonZ2vH1lxMYTW4CELbLRCHWc6WDF/C7xiXOsTr+0kwrUZ/ee4kTVxJHMb3+T3GlzPIopEKai6 tLLOsAQqbkl4SlpEmtxtuuNufWNkCDVlJgaMGgGbAawHNHfivfVYz17kLtC1j7PyA4s7XyKABrtxI TEY0OfLw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWET1-0001XI-IZ; Sat, 24 Oct 2020 07:59:59 +0000 Date: Sat, 24 Oct 2020 08:59:59 +0100 From: Christoph Hellwig To: Roman Gushchin Cc: Andrew Morton , Zi Yan , Joonsoo Kim , Mike Kravetz , saberlily.xia@hisilicon.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH v1 1/2] mm: cma: introduce cma_release_nowait() Message-ID: <20201024075959.GA4285@infradead.org> References: <20201022225308.2927890-1-guro@fb.com> <20201022225308.2927890-2-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022225308.2927890-2-guro@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Btw, I think we also need to use this nonblocking version from dma_free_contiguous. dma_free* is defined to not block. In practice callers mostly care if they also did GFP_ATOMIC allocations, which don't dip into CMA, but I think we do have a problem.