From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CD4C2D0A3 for ; Thu, 29 Oct 2020 20:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90AEF20791 for ; Thu, 29 Oct 2020 20:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbgJ2UFh (ORCPT ); Thu, 29 Oct 2020 16:05:37 -0400 Received: from mga18.intel.com ([134.134.136.126]:56816 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgJ2UFh (ORCPT ); Thu, 29 Oct 2020 16:05:37 -0400 IronPort-SDR: 3lIDUOhAjlIu+l2RhGFhiAjpjkuE4ObmUz4Fpuo4bAhM6jEBygZ6dfRCDtqyFx9ZrOjfP97noh d9hZztxaivmg== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="156277426" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="156277426" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 13:05:36 -0700 IronPort-SDR: qTYwAZ6BG2b7vt/5azhvXjAYOh+vwOxZJ/y7lNX2/1lNLSD/jPTfPWnHI3p3LxEf/sXkDNuEjp tcfKINEi/0Uw== X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="469262735" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 13:05:35 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kYEBy-001UIn-Ew; Thu, 29 Oct 2020 22:06:38 +0200 Date: Mon, 26 Oct 2020 15:14:27 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] devres: zero the memory in devm_krealloc() if needed Message-ID: <20201026131427.GF4077@smile.fi.intel.com> References: <20201026122728.8522-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026122728.8522-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2020 at 01:27:28PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > If we're returning the same pointer (when new size is smaller or equal > to the old size) we need to check if the user wants the memory zeroed > and memset() it manually if so. Any use case? Because to me it sounds contradictory to the whole idea of [k]realloc(). -- With Best Regards, Andy Shevchenko