From: Peter Zijlstra <peterz@infradead.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
"Paul E. McKenney" <paulmck@kernel.org>,
Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seqlock: avoid -Wshadow warnings
Date: Mon, 26 Oct 2020 17:58:05 +0100 [thread overview]
Message-ID: <20201026165805.GS2594@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201026165044.3722931-1-arnd@kernel.org>
On Mon, Oct 26, 2020 at 05:50:38PM +0100, Arnd Bergmann wrote:
> - unsigned seq; \
> + unsigned __seq; \
> - unsigned seq = __read_seqcount_begin(s); \
> + unsigned _seq = __read_seqcount_begin(s); \
> - unsigned seq = __seqcount_sequence(s); \
> + unsigned __seq = __seqcount_sequence(s); \
Can we have a consistent number of leading '_' ?
Also, I suppose you're going to find the explicit shadow in
___wait_event(), that one's not going to be trivial to fix.
next prev parent reply other threads:[~2020-10-26 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:50 [PATCH] seqlock: avoid -Wshadow warnings Arnd Bergmann
2020-10-26 16:58 ` Peter Zijlstra [this message]
2020-10-27 23:34 ` Arnd Bergmann
2020-10-28 7:51 ` Rasmus Villemoes
2020-10-28 8:51 ` Peter Zijlstra
2020-12-03 10:35 ` [tip: locking/core] " tip-bot2 for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026165805.GS2594@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.darwish@linutronix.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox