Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

Daniel Vetter
2020-10-27T09:33:59Z

On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc -Wextra notices that one of the fields in psbfb_roll_ops has two
> initializers:
>
> drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init]
>
> Open-code this instead, leaving out the extraneous initializers for
> .fb_pan_display.
>
> Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd
just garbage-collect this, maybe als the entire accelerator code and just
leave psbfb_unaccel_ops behind ...
-Daniel

> ---
> drivers/gpu/drm/gma500/framebuffer.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
> index 54d9876b5305..a56a6b53fac6 100644
> --- a/drivers/gpu/drm/gma500/framebuffer.c
> +++ b/drivers/gpu/drm/gma500/framebuffer.c
> @@ -177,7 +177,14 @@ static const struct fb_ops psbfb_ops = {
>
> static const struct fb_ops psbfb_roll_ops = {
> .owner = THIS_MODULE,
> - DRM_FB_HELPER_DEFAULT_OPS,
> + .fb_check_var = drm_fb_helper_check_var,
> + .fb_set_par = drm_fb_helper_set_par,
> + .fb_setcmap = drm_fb_helper_setcmap,
> + .fb_blank = drm_fb_helper_blank,
> + .fb_debug_enter = drm_fb_helper_debug_enter,
> + .fb_debug_leave = drm_fb_helper_debug_leave,
> + .fb_ioctl = drm_fb_helper_ioctl,
> +
> .fb_setcolreg = psbfb_setcolreg,
> .fb_fillrect = drm_fb_helper_cfb_fillrect,
> .fb_copyarea = drm_fb_helper_cfb_copyarea,
> --
> 2.27.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation