From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Dennis Zhou <dennis@kernel.org>,
Christoph Lameter <cl@linux.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asm-generic: percpu: avoid Wshadow warning
Date: Mon, 26 Oct 2020 22:03:12 +0100 [thread overview]
Message-ID: <20201026210312.byq3mdo4e2ei6ee2@ltop.local> (raw)
In-Reply-To: <20201026155353.3702892-1-arnd@kernel.org>
On Mon, Oct 26, 2020 at 04:53:48PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Nesting macros that use the same local variable names causes
> warnings when building with "make W=2":
>
> include/asm-generic/percpu.h:117:14: warning: declaration of '__ret' shadows a previous local [-Wshadow]
> include/asm-generic/percpu.h:126:14: warning: declaration of '__ret' shadows a previous local [-Wshadow]
>
> These are fairly harmless, but since the warning comes from
> a global header, the warning happens every time the headers
> are included, which is fairly annoying.
>
> Rename the variables to avoid shadowing and shut up the warning.
Looks good to me. Fell free to add my:
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
next prev parent reply other threads:[~2020-10-26 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 15:53 [PATCH] asm-generic: percpu: avoid Wshadow warning Arnd Bergmann
2020-10-26 21:03 ` Luc Van Oostenryck [this message]
2020-10-27 0:02 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026210312.byq3mdo4e2ei6ee2@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox