From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F200EC4363A for ; Tue, 27 Oct 2020 00:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2B6F20780 for ; Tue, 27 Oct 2020 00:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603758445; bh=nv0alUetsUhi2J02Q1vOFwER03xPOHSfPLkUcaPHIuQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JbJrikRDU8Cj0mGftW6t76F53IM3d8sDllNKcdjCvTFfFUn/eyv+kWTvuD1FFvRjb 7azlJvlRGhJvKMGXWd880VCtCW/zbz1MWEiw57RcsFsvdxZ3EK8WPywl01H9cu/BZh jJMFIxH2IiGhRY4z3sw9UNKS1zKeq3v+fbaUxKF4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439199AbgJ0A1X (ORCPT ); Mon, 26 Oct 2020 20:27:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:58022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410099AbgJZXxa (ORCPT ); Mon, 26 Oct 2020 19:53:30 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62A07221FA; Mon, 26 Oct 2020 23:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603756410; bh=nv0alUetsUhi2J02Q1vOFwER03xPOHSfPLkUcaPHIuQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ky7i+//D/SjiUWPKZD7Vi7t8y7ZHA6RgWrzIAvZCHnz9IpKvoHipkR6pvNlL7Vp3z knXLoP90lX1FBmAjGQvN1b7kGYoyp2XpqvnNb4ZctZ7jhh86i8qYKhk7xNzqHV0gop g9vgVXN7ZWP5JOFBfl8ZDzsOxMmr2ZuQdOfNlmVk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luben Tuikov , Slava Abramov , Alex Deucher , Sasha Levin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.8 068/132] drm/amdgpu: No sysfs, not an error condition Date: Mon, 26 Oct 2020 19:51:00 -0400 Message-Id: <20201026235205.1023962-68-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026235205.1023962-1-sashal@kernel.org> References: <20201026235205.1023962-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luben Tuikov [ Upstream commit 5aea5327ea2ddf544cbeff096f45fc2319b0714e ] Not being able to create amdgpu sysfs attributes is not a fatal error warranting not to continue to try to bring up the display. Thus, if we get an error trying to create amdgpu sysfs attrs, report it and continue on to try to bring up a display. Signed-off-by: Luben Tuikov Acked-by: Slava Abramov Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index a027a8f7b2819..21c56d5b05999 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -3275,10 +3275,8 @@ int amdgpu_device_init(struct amdgpu_device *adev, msecs_to_jiffies(AMDGPU_RESUME_MS)); r = sysfs_create_files(&adev->dev->kobj, amdgpu_dev_attributes); - if (r) { + if (r) dev_err(adev->dev, "Could not create amdgpu device attr\n"); - return r; - } if (IS_ENABLED(CONFIG_PERF_EVENTS)) r = amdgpu_pmu_init(adev); -- 2.25.1