public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Oliver O'Halloran <oohall@gmail.com>,
	Joel Stanley <joel@jms.id.au>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Sasha Levin <sashal@kernel.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH AUTOSEL 4.14 01/46] powerpc/powernv/smp: Fix spurious DBG() warning
Date: Mon, 26 Oct 2020 20:09:00 -0400	[thread overview]
Message-ID: <20201027000946.1026923-1-sashal@kernel.org> (raw)

From: Oliver O'Halloran <oohall@gmail.com>

[ Upstream commit f6bac19cf65c5be21d14a0c9684c8f560f2096dd ]

When building with W=1 we get the following warning:

 arch/powerpc/platforms/powernv/smp.c: In function ‘pnv_smp_cpu_kill_self’:
 arch/powerpc/platforms/powernv/smp.c:276:16: error: suggest braces around
 	empty body in an ‘if’ statement [-Werror=empty-body]
   276 |      cpu, srr1);
       |                ^
 cc1: all warnings being treated as errors

The full context is this block:

 if (srr1 && !generic_check_cpu_restart(cpu))
 	DBG("CPU%d Unexpected exit while offline srr1=%lx!\n",
 			cpu, srr1);

When building with DEBUG undefined DBG() expands to nothing and GCC emits
the warning due to the lack of braces around an empty statement.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200804005410.146094-2-oohall@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/powerpc/platforms/powernv/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/powernv/smp.c
index c17f81e433f7d..11d8fde770c38 100644
--- a/arch/powerpc/platforms/powernv/smp.c
+++ b/arch/powerpc/platforms/powernv/smp.c
@@ -44,7 +44,7 @@
 #include <asm/udbg.h>
 #define DBG(fmt...) udbg_printf(fmt)
 #else
-#define DBG(fmt...)
+#define DBG(fmt...) do { } while (0)
 #endif
 
 static void pnv_smp_setup_cpu(int cpu)
-- 
2.25.1


             reply	other threads:[~2020-10-27  0:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  0:09 Sasha Levin [this message]
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 02/46] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 03/46] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 04/46] f2fs: add trace exit in exception path Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 05/46] f2fs: fix to check segment boundary during SIT page readahead Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 06/46] um: change sigio_spinlock to a mutex Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 07/46] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 08/46] ARM: 8997/2: hw_breakpoint: Handle inexact watchpoint addresses Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 09/46] xfs: fix realtime bitmap/summary file truncation when growing rt volume Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 10/46] video: fbdev: pvr2fb: initialize variables Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 11/46] ath10k: start recovery process when payload length exceeds max htc length for sdio Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 12/46] ath10k: fix VHT NSS calculation when STBC is enabled Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 13/46] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 14/46] media: videodev2.h: RGB BT2020 and HSV are always full range Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 15/46] media: platform: Improve queue set up flow for bug fixing Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 16/46] usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 17/46] media: tw5864: check status of tw5864_frameinterval_get Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 18/46] mmc: via-sdmmc: Fix data race bug Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 19/46] drm/bridge/synopsys: dsi: add support for non-continuous HS clock Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 20/46] printk: reduce LOG_BUF_SHIFT range for H8300 Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 21/46] kgdb: Make "kgdbcon" work properly with "kgdb_earlycon" Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 22/46] cpufreq: sti-cpufreq: add stih418 support Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 23/46] USB: adutux: fix debugging Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 24/46] uio: free uio id after uio file node is freed Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 25/46] arm64/mm: return cpu_all_mask when node is NUMA_NO_NODE Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 26/46] ACPI: Add out of bounds and numa_off protections to pxm_to_node() Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 27/46] dm: change max_io_len() to use blk_max_size_offset() Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 28/46] drivers/net/wan/hdlc_fr: Correctly handle special skb->protocol values Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 29/46] bus/fsl_mc: Do not rely on caller to provide non NULL mc_io Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 30/46] power: supply: test_power: add missing newlines when printing parameters by sysfs Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 31/46] md/bitmap: md_bitmap_get_counter returns wrong blocks Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 32/46] bnxt_en: Log unknown link speed appropriately Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 33/46] clk: ti: clockdomain: fix static checker warning Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 34/46] asm-generic/io.h: Fix !CONFIG_GENERIC_IOMAP pci_iounmap() implementation Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 35/46] net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 36/46] drivers: watchdog: rdc321x_wdt: Fix race condition bugs Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 37/46] ext4: Detect already used quota file early Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 38/46] gfs2: add validation checks for size of superblock Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 39/46] arm64: dts: renesas: ulcb: add full-pwr-cycle-in-suspend into eMMC nodes Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 40/46] memory: emif: Remove bogus debugfs error handling Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 41/46] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 42/46] ARM: dts: s5pv210: move PMU node out of clock controller Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 43/46] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 44/46] nbd: make the config put is called before the notifying the waiter Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 45/46] sgl_alloc_order: fix memory leak Sasha Levin
2020-10-27  0:09 ` [PATCH AUTOSEL 4.14 46/46] nvme-rdma: fix crash when connect rejected Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027000946.1026923-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oohall@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox