From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED617C56202 for ; Tue, 27 Oct 2020 00:16:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADF0A207C4 for ; Tue, 27 Oct 2020 00:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757806; bh=DSTCBacfg70c3TQg/1+roX05NydpKm67oiv0xY7l8xA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bVwgi+L5yXB+qhJsER+Yc5T07qj0iPtqQwJ8/UmFWATtZhiSizgu+Vhe9Kf9TJ4P/ AETjjZxCOZXWME1O96mN7nTbJ3N3JMBfI21v17j1NWU3cy8uszdMSFYd6ZbU5byORA vEcqrBrpQ9xkmmYKzzov1oOaCk4ne7mKCWZpAmR8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411565AbgJ0AKj (ORCPT ); Mon, 26 Oct 2020 20:10:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:59210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439191AbgJ0AKT (ORCPT ); Mon, 26 Oct 2020 20:10:19 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71DE521D41; Tue, 27 Oct 2020 00:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757419; bh=DSTCBacfg70c3TQg/1+roX05NydpKm67oiv0xY7l8xA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UE+MBo18jhsCdyH6ZIJBZn7Cs7Dt2NucSuueFpvjpaFgPticZG20nufLC6iOxuI2y quVEcqRntSq1KqBHFJgmT4GpfNjyNgHEL08cfWSwJyp1MC09uURSjk0g1pcMPrxeoh dGo9ESYJyzhMa49jTi1tXZwog/7w4T0gx9vzPdOk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Snitzer , Sasha Levin , dm-devel@redhat.com Subject: [PATCH AUTOSEL 4.14 27/46] dm: change max_io_len() to use blk_max_size_offset() Date: Mon, 26 Oct 2020 20:09:26 -0400 Message-Id: <20201027000946.1026923-27-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201027000946.1026923-1-sashal@kernel.org> References: <20201027000946.1026923-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Snitzer [ Upstream commit 5091cdec56faeaefa79de4b6cb3c3c55e50d1ac3 ] Using blk_max_size_offset() enables DM core's splitting to impose ti->max_io_len (via q->limits.chunk_sectors) and also fallback to respecting q->limits.max_sectors if chunk_sectors isn't set. Signed-off-by: Mike Snitzer Signed-off-by: Sasha Levin --- drivers/md/dm.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 6e741f19a732e..50db2cbeb10a1 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -891,22 +891,18 @@ static sector_t max_io_len_target_boundary(sector_t sector, struct dm_target *ti static sector_t max_io_len(sector_t sector, struct dm_target *ti) { sector_t len = max_io_len_target_boundary(sector, ti); - sector_t offset, max_len; + sector_t max_len; /* * Does the target need to split even further? + * - q->limits.chunk_sectors reflects ti->max_io_len so + * blk_max_size_offset() provides required splitting. + * - blk_max_size_offset() also respects q->limits.max_sectors */ - if (ti->max_io_len) { - offset = dm_target_offset(ti, sector); - if (unlikely(ti->max_io_len & (ti->max_io_len - 1))) - max_len = sector_div(offset, ti->max_io_len); - else - max_len = offset & (ti->max_io_len - 1); - max_len = ti->max_io_len - max_len; - - if (len > max_len) - len = max_len; - } + max_len = blk_max_size_offset(dm_table_get_md(ti->table)->queue, + dm_target_offset(ti, sector)); + if (len > max_len) + len = max_len; return len; } -- 2.25.1