From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDE5C2D0A3 for ; Tue, 27 Oct 2020 00:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D01FA20791 for ; Tue, 27 Oct 2020 00:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757588; bh=5dw8bp377Q3VfyFt5ZaoKeAJ61WPvUdcSWlnw0Cs76Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pB7j7STdNO9vMAOWVJylvxOWN0krsZnWIbs3N+zzRyCW9+4BMpQ8j3PUB+Y3AU2FZ tEsr6VNznTjef8H5Yj+wWyhCq7O9RGv4xtk0BWVvD32y/lo7ugmbNogSBzkAuCDGRu y46+K4GFwq2uVZHwSkfSSgUQPsA0i4Fk5UINc30c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411842AbgJ0ALy (ORCPT ); Mon, 26 Oct 2020 20:11:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:60720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439251AbgJ0ALK (ORCPT ); Mon, 26 Oct 2020 20:11:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DFB7217A0; Tue, 27 Oct 2020 00:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757470; bh=5dw8bp377Q3VfyFt5ZaoKeAJ61WPvUdcSWlnw0Cs76Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LmMSWW4WqqIznygMLtHMy5EdUlGrgQG7BuxvnFR7UwQWd1nydB03dyWREBKQxge37 hdLg+5nIL13pVo3nKBdOOksB3QRZUZc8RscIcM0OPOss95s6VRanxF/C6Ub+wVHKkf cTFLR5RKlltgWc4qdn9noKDSyw/iuj88pRNsecMA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tero Kristo , Dan Murphy , Stephen Boyd , Sasha Levin , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 22/30] clk: ti: clockdomain: fix static checker warning Date: Mon, 26 Oct 2020 20:10:36 -0400 Message-Id: <20201027001044.1027349-22-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201027001044.1027349-1-sashal@kernel.org> References: <20201027001044.1027349-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit b7a7943fe291b983b104bcbd2f16e8e896f56590 ] Fix a memory leak induced by not calling clk_put after doing of_clk_get. Reported-by: Dan Murphy Signed-off-by: Tero Kristo Link: https://lore.kernel.org/r/20200907082600.454-3-t-kristo@ti.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clockdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index 6cf9dd189a924..4e5e952380869 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -124,10 +124,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) if (clk_hw_get_flags(clk_hw) & CLK_IS_BASIC) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); + clk_put(clk); continue; } to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name; omap2_init_clk_clkdm(clk_hw); + clk_put(clk); } } -- 2.25.1