From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB04C4363A for ; Tue, 27 Oct 2020 00:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D49FD20754 for ; Tue, 27 Oct 2020 00:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757645; bh=LOs2ic7kUCAtLOVQFQXO7gcnQiewmk0p48xl6tzGisA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e3oECX5/xwuoqCAXqvf4q6kisqqR3h6k7ahWLOdV1xiLufe6TB8wtofjf4Wng/uFb HKoLqNocj4A5r7feoopMHu4vIBzX4a9QRPC8iuCJ0SKomw2tcsfO87eNV3vHxoDgM0 L5cyQcK64GfiBqtS5YgaucDOWicfF1F6hF5QFeLE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439548AbgJ0AOE (ORCPT ); Mon, 26 Oct 2020 20:14:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:33300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2411773AbgJ0ALe (ORCPT ); Mon, 26 Oct 2020 20:11:34 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BE7421741; Tue, 27 Oct 2020 00:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603757494; bh=LOs2ic7kUCAtLOVQFQXO7gcnQiewmk0p48xl6tzGisA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=itT/0s1it8eSvsbdi5l6PeHftMY2Zv8pnwDBJmcZ3cATqBV5Id+St6oF/sxkWxIJm L2efUDFi4a0mU6cVqhzm4SgF6E/TVC/FJpKr1FGx9yUf5yZah+6XKv0REvMBOHCxAk u4Y6Unf8qGqSQael3FGXfhyZwjmiXPlLb7s5gXbk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Madhuparna Bhowmik , Ulf Hansson , Sasha Levin , linux-mmc@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 08/25] mmc: via-sdmmc: Fix data race bug Date: Mon, 26 Oct 2020 20:11:06 -0400 Message-Id: <20201027001123.1027642-8-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201027001123.1027642-1-sashal@kernel.org> References: <20201027001123.1027642-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madhuparna Bhowmik [ Upstream commit 87d7ad089b318b4f319bf57f1daa64eb6d1d10ad ] via_save_pcictrlreg() should be called with host->lock held as it writes to pm_pcictrl_reg, otherwise there can be a race condition between via_sd_suspend() and via_sdc_card_detect(). The same pattern is used in the function via_reset_pcictrl() as well, where via_save_pcictrlreg() is called with host->lock held. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Madhuparna Bhowmik Link: https://lore.kernel.org/r/20200822061528.7035-1-madhuparnabhowmik10@gmail.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/via-sdmmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c index 63fac78b3d46a..b455e9cf95afc 100644 --- a/drivers/mmc/host/via-sdmmc.c +++ b/drivers/mmc/host/via-sdmmc.c @@ -1269,11 +1269,14 @@ static void via_init_sdc_pm(struct via_crdr_mmc_host *host) static int via_sd_suspend(struct pci_dev *pcidev, pm_message_t state) { struct via_crdr_mmc_host *host; + unsigned long flags; host = pci_get_drvdata(pcidev); + spin_lock_irqsave(&host->lock, flags); via_save_pcictrlreg(host); via_save_sdcreg(host); + spin_unlock_irqrestore(&host->lock, flags); pci_save_state(pcidev); pci_enable_wake(pcidev, pci_choose_state(pcidev, state), 0); -- 2.25.1