Re: [PATCH v3 31/56] usb: dwc3: fix kernel-doc markups

Felipe Balbi
2020-10-29T01:00:28Z

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Tue, Oct 27, 2020 at 08:58:47AM +0200, Felipe Balbi wrote:
>>
>> Hi Mauro,
>>
>> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
>> > There is a common comment marked, instead, with kernel-doc
>> > notation.
>> >
>> > Also, some identifiers have different names between their
>> > prototypes and the kernel-doc markup.
>> >
>> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>> > ---
>> > drivers/usb/dwc3/core.c | 2 +-
>> > drivers/usb/dwc3/core.h | 2 +-
>> > drivers/usb/gadget/composite.c | 2 +-
>> > drivers/usb/typec/mux.c | 2 +-
>> > include/linux/usb/composite.h | 2 +-
>>
>> mind breaking this into 4 commits? One for dwc3, one for
>> gadget/composite, one for type/mux, and a final for composite.h.
>
> I'll just take these all at once, it's easy enough :)

Sure thing, in that case:

Acked-by: Felipe Balbi <balbi@kernel.org>

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]