Re: [PATCH v6 06/52] dt-bindings: memory: tegra20: emc: Document new interconnect property

Krzysztof Kozlowski
2020-10-27T09:03:11Z

On Mon, Oct 26, 2020 at 01:16:49AM +0300, Dmitry Osipenko wrote:
> External Memory Controller is interconnected with memory controller and
> with external memory. Document new interconnect property which turns EMC
> into interconnect provider.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
> index 1b0d4417aad8..0a53adc6ccba 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
> @@ -13,6 +13,7 @@ Properties:
> - interrupts : Should contain EMC General interrupt.
> - clocks : Should contain EMC clock.
> - nvidia,memory-controller : Phandle of the Memory Controller node.
> +- #interconnect-cells : Should be 0.
>
> Child device nodes describe the memory settings for different configurations and clock rates.
>
> @@ -21,6 +22,7 @@ Example:
> memory-controller@7000f400 {
> #address-cells = < 1 >;
> #size-cells = < 0 >;
> + #interconnect-cells = < 0 >;

No spaces within <>. I see existing example, but bad pattern should not
be continued just because it is already there.

Best regards,
Krzysztof