Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

Dmitry Osipenko
2020-10-27T21:12:10Z

27.10.2020 23:22, Dmitry Osipenko пишет:
...
>>> +
>>> + *agg_avg += avg_bw;
>>> + *agg_peak = max(*agg_peak, peak_bw);
>>
>> I'm not very familiar with ICC, but shouldn't the aggregated peak value
>> be the sum of the current aggregated peak and the new peak bandwidth?
>> Currently you're selecting the maximum peak bandwidth across all
>> clients, so isn't that going to be too small if for whatever reason
>> multiple clients need peak bandwidth at the same time?

The current variant with max-peak selection should be okay since it
takes into account the competing ISO bandwidths of other devices by
overestimating the bandwidth.

For now we have only display ISO clients and it won't be a problem to
tune the algorithm later on if it won't work well for other ISO clients.