From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59AD6C4363A for ; Tue, 27 Oct 2020 09:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F20C22258 for ; Tue, 27 Oct 2020 09:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506178AbgJ0JTl (ORCPT ); Tue, 27 Oct 2020 05:19:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:32796 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505970AbgJ0JTk (ORCPT ); Tue, 27 Oct 2020 05:19:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C6B4B02D; Tue, 27 Oct 2020 09:19:39 +0000 (UTC) Date: Tue, 27 Oct 2020 09:19:36 +0000 From: Mel Gorman To: Julia Lawall Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched/fair: check for idle core Message-ID: <20201027091936.GS32041@suse.de> References: <1603372550-14680-1-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1603372550-14680-1-git-send-email-Julia.Lawall@inria.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in wakeup path") > Signed-off-by: Julia Lawall > Reviewed-by Vincent Guittot > While not a universal win, it was mostly a win or neutral. In few cases where there was a problem, one benchmark I'm a bit suspicious of generally as occasionally it generates bad results for unknown and unpredictable reasons. In another, it was very machine specific and the differences were small in absolte time rather than relative time. Other tests on the same machine were fine so overall; Acked-by: Mel Gorman Thanks. -- Mel Gorman SUSE Labs