From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype
Date: Tue, 27 Oct 2020 09:30:57 +0900 [thread overview]
Message-ID: <20201027093057.c685a14b386acacb3c449e3d@kernel.org> (raw)
In-Reply-To: <20201026221241.3897396-1-arnd@kernel.org>
On Mon, 26 Oct 2020 23:12:00 +0100
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With extra warnings enabled, gcc complains about this function
> definition:
>
> arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
> arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
> 465 | int __init arch_init_kprobes()
>
> Fixes: 24ba613c9d6c ("ARM kprobes: core code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks Arnd!
> ---
> arch/arm/probes/kprobes/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c
> index a9653117ca0d..e513d8a46776 100644
> --- a/arch/arm/probes/kprobes/core.c
> +++ b/arch/arm/probes/kprobes/core.c
> @@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
>
> #endif /* !CONFIG_THUMB2_KERNEL */
>
> -int __init arch_init_kprobes()
> +int __init arch_init_kprobes(void)
> {
> arm_probes_decode_init();
> #ifdef CONFIG_THUMB2_KERNEL
> --
> 2.27.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-10-27 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 22:12 [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype Arnd Bergmann
2020-10-27 0:30 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027093057.c685a14b386acacb3c449e3d@kernel.org \
--to=mhiramat@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox