From: Peter Zijlstra <peterz@infradead.org>
To: tglx@linutronix.de, luto@kernel.org, me@kylehuey.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, rocallahan@gmail.com,
alexandre.chartre@oracle.com, paulmck@kernel.org,
frederic@kernel.org, pbonzini@redhat.com,
sean.j.christopherson@intel.com, mhiramat@kernel.org,
pmladek@suse.com, joel@joelfernandes.org, rostedt@goodmis.org,
boris.ostrovsky@oracle.com, jgross@suse.com, brgerst@gmail.com,
jpoimboe@redhat.com, daniel.thompson@linaro.org,
julliard@winehq.org, pgofman@codeweavers.com,
peterz@infradead.org
Subject: [PATCH 3/3] x86/debug: Fix PTRACE_{BLOCK,SINGLE}STEP vs ptrace_get_debugreg(6)
Date: Tue, 27 Oct 2020 10:15:07 +0100 [thread overview]
Message-ID: <20201027093608.096535386@infradead.org> (raw)
In-Reply-To: 20201027091504.712183781@infradead.org
Commit d53d9bc0cf78 ("x86/debug: Change thread.debugreg6 to
thread.virtual_dr6") changed the semantics of the variable from random
collection of bits, to exactly only those bits that ptrace() needs.
Unfortunately we lost DR_STEP for PTRACE_{BLOCK,SINGLE}STEP.
Fixes: d53d9bc0cf78 ("x86/debug: Change thread.debugreg6 to thread.virtual_dr6")
Reported-by: Kyle Huey <me@kylehuey.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
arch/x86/include/asm/ptrace.h | 2 ++
arch/x86/kernel/step.c | 9 +++++++++
arch/x86/kernel/traps.c | 2 +-
3 files changed, 12 insertions(+), 1 deletion(-)
--- a/arch/x86/include/asm/ptrace.h
+++ b/arch/x86/include/asm/ptrace.h
@@ -355,6 +355,8 @@ static inline unsigned long regs_get_ker
#define arch_has_block_step() (boot_cpu_data.x86 >= 6)
#endif
+extern unsigned long user_dr_step(unsigned long dr6);
+
#define ARCH_HAS_USER_SINGLE_STEP_REPORT
struct user_desc;
--- a/arch/x86/kernel/step.c
+++ b/arch/x86/kernel/step.c
@@ -235,3 +235,12 @@ void user_disable_single_step(struct tas
if (test_and_clear_tsk_thread_flag(child, TIF_FORCED_TF))
task_pt_regs(child)->flags &= ~X86_EFLAGS_TF;
}
+
+unsigned long user_dr_step(unsigned long dr6)
+{
+ if (test_thread_flag(TIF_BLOCKSTEP) ||
+ test_thread_flag(TIF_SINGLESTEP))
+ return dr6 & DR_STEP;
+
+ return 0;
+}
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -940,7 +940,7 @@ static __always_inline void exc_debug_us
* Clear the virtual DR6 value, ptrace() routines will set bits here
* for things it wants signals for.
*/
- current->thread.virtual_dr6 = 0;
+ current->thread.virtual_dr6 = user_dr_step(dr6);
/*
* The SDM says "The processor clears the BTF flag when it
next prev parent reply other threads:[~2020-10-27 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 9:15 [PATCH 0/3] x86/debug: Fixes Peter Zijlstra
2020-10-27 9:15 ` [PATCH 1/3] x86/debug: Fix BTF handling Peter Zijlstra
2020-10-27 19:41 ` Peter Zijlstra
2020-10-28 9:20 ` Masami Hiramatsu
2020-10-28 9:59 ` Peter Zijlstra
2020-10-28 12:11 ` Masami Hiramatsu
2020-10-28 14:31 ` [PATCH] x86/kprobes: Restore BTF if the single-stepping is cancelled Masami Hiramatsu
2020-12-07 23:22 ` Steven Rostedt
2020-12-09 18:44 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2020-10-27 22:19 ` [tip: x86/urgent] x86/debug: Fix BTF handling tip-bot2 for Peter Zijlstra
2020-10-27 9:15 ` [PATCH 2/3] x86/debug: Only clear/set ->virtual_dr6 for userspace #DB Peter Zijlstra
2020-10-27 22:19 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2020-10-27 9:15 ` Peter Zijlstra [this message]
2020-10-27 17:22 ` [PATCH 3/3] x86/debug: Fix PTRACE_{BLOCK,SINGLE}STEP vs ptrace_get_debugreg(6) Kyle Huey
2020-10-27 18:33 ` [PATCH v2 3/3] Fix DR_STEP " Peter Zijlstra
2020-10-27 22:19 ` [tip: x86/urgent] x86/debug: " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027093608.096535386@infradead.org \
--to=peterz@infradead.org \
--cc=alexandre.chartre@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brgerst@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=frederic@kernel.org \
--cc=jgross@suse.com \
--cc=joel@joelfernandes.org \
--cc=jpoimboe@redhat.com \
--cc=julliard@winehq.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pgofman@codeweavers.com \
--cc=pmladek@suse.com \
--cc=rocallahan@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox