Re: [PATCH 4.19 228/264] PM: hibernate: remove the bogus call to get_gendisk() in software_resume()

Christoph Hellwig
2020-10-28T22:32:35Z

On Wed, Oct 28, 2020 at 08:10:57AM +0100, Pavel Machek wrote:
> This does not fix anything in 4.19, and should not be there.
>
> It will break resume for people using resumewait option and using
> numeric values, as original changelog explains. Eventually, someone
> will cry regression and we'll have to fix it in the mainline, but no
> need to bring this to -stable, too.

If this code ever gets hit this patch fixes a reference count leak.