From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94992C4363A for ; Tue, 27 Oct 2020 17:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D85B2464B for ; Tue, 27 Oct 2020 17:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603820879; bh=/l6hrO7GPupnXbyvP/nFnCmESAppWg17z8tPranVdBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FsJ/WUDxwS2d8G4Po9fJ4B7pOPjo57C0bnpp8yFx0idWK5DkCOz2xlXj6vIGXpLCF ywIYdKWcPapB4w3XO8q1NVB4i2lVuTHB+oAu9PUVQaPODzzW/GgrQStE8JL2SpbN6L FZZez+j1keYbfWv1XmT4uraInq48q092A18u5dYQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1822202AbgJ0Rr6 (ORCPT ); Tue, 27 Oct 2020 13:47:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:53482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759046AbgJ0O1Y (ORCPT ); Tue, 27 Oct 2020 10:27:24 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05A22207C3; Tue, 27 Oct 2020 14:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808841; bh=/l6hrO7GPupnXbyvP/nFnCmESAppWg17z8tPranVdBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PxFy/5kgidkwMBBUMXD4uN6C1OKdE4XpHHq30oKuKGEIBrFKBiTfyai1SdZyw8EFw HGnPkiR6p+MyKv50RdwW7hJV/Emq4ePZYVPRXdtsjptXtvaHx0IntUQJx4oXTRMTcc iI21pX+DiZ/VHXEa6CguxzQIvEeTe84RPck4bCv4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 214/264] media: exynos4-is: Fix a reference count leak Date: Tue, 27 Oct 2020 14:54:32 +0100 Message-Id: <20201027135440.730491722@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu [ Upstream commit 64157b2cb1940449e7df2670e85781c690266588 ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/mipi-csis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index b4e28a299e26e..efab3ebc67564 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -513,8 +513,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable) if (enable) { s5pcsis_clear_counters(state); ret = pm_runtime_get_sync(&state->pdev->dev); - if (ret && ret != 1) + if (ret && ret != 1) { + pm_runtime_put_noidle(&state->pdev->dev); return ret; + } } mutex_lock(&state->lock); -- 2.25.1