From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA926C388F9 for ; Tue, 27 Oct 2020 15:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80D2D20728 for ; Tue, 27 Oct 2020 15:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812622; bh=9agzTw2lxEcHyiQ7pb1YWlvOVAsdUWDDOwoSjGA03co=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nT+WNnEgFhSOSTVn1Pt9rrNlQjbulf0lkmP86iF3Q3FbWf+wMy4h7mMZXcgeH8y3g 7x/oJYObfpxJJRBlrzIxUY1mU6RfHKSxahLmbwSkS8fga9GoDZiDhcKdmbzOR7q0AB x+jtJZaAGiklEOGRa2aJzedN0vfsz8pdQTi7dW04= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799213AbgJ0PaT (ORCPT ); Tue, 27 Oct 2020 11:30:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:38486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1797426AbgJ0PX3 (ORCPT ); Tue, 27 Oct 2020 11:23:29 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C7A12076D; Tue, 27 Oct 2020 15:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812208; bh=9agzTw2lxEcHyiQ7pb1YWlvOVAsdUWDDOwoSjGA03co=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jrbIxC/pDveTVgPmVVL7IJHyT2ZdKfEwGzPyL0Cbo3EAXWXfMlXqbmqlmnuFlWmFv WwB/lAff4l2NJBW6vDYi008JANuJxwWsDfI99yM48UEpAs/wdSVdgeL3vpAJ2BL52v okIp/QQpMcxbMO/6apo/J2mlxzl9DqGBsvMureo8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Kocialkowski , Jacopo Mondi , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.9 129/757] media: ov5640: Correct Bit Div register in clock tree diagram Date: Tue, 27 Oct 2020 14:46:19 +0100 Message-Id: <20201027135456.631718124@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Kocialkowski [ Upstream commit 4c85f628f6639e3e3e0a7788416154f28dfcae4f ] Although the code is correct and doing the right thing, the clock diagram showed the wrong register for the bit divider, which had me doubting the understanding of the tree. Fix this to avoid doubts in the future. Signed-off-by: Paul Kocialkowski Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate") Acked-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 2fe4a7ac05929..ab19e04720d3a 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -751,7 +751,7 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, u16 reg, * +->| PLL Root Div | - reg 0x3037, bit 4 * +-+------------+ * | +---------+ - * +->| Bit Div | - reg 0x3035, bits 0-3 + * +->| Bit Div | - reg 0x3034, bits 0-3 * +-+-------+ * | +-------------+ * +->| SCLK Div | - reg 0x3108, bits 0-1 -- 2.25.1