From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69D8C55179 for ; Tue, 27 Oct 2020 15:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E7D22224A for ; Tue, 27 Oct 2020 15:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812413; bh=BXlS800SwGQrPnsXmMwxDYcht6XMTLARhE1KxqLI9Xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=flGpcSmETi0VbGhnWHuLA5m/8IO/lO8lDnIpXjCGFS9AD5uU1U4Lxn4ZSU1vl2zqQ 53UizGnOG/0H7vtKJmI9a6swT/a7YahfbUJKJEzgK/SyJ4Xy49UA4jiiKV4kLoT19e Mi7/LIC+KQokMTorgCenn9NI5c1hBPkF2dmVo848= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1797664AbgJ0PYq (ORCPT ); Tue, 27 Oct 2020 11:24:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:38550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1797431AbgJ0PXc (ORCPT ); Tue, 27 Oct 2020 11:23:32 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0CCD2064B; Tue, 27 Oct 2020 15:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812211; bh=BXlS800SwGQrPnsXmMwxDYcht6XMTLARhE1KxqLI9Xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UdKt4AFEAIcxRC5Ii0i+G6PzerUF9hM5uR280CPadbQ0vTnvaTEQzpi0JI+wwqMi7 YHl/c1rou2WTllgL2beto2RYNMhaXanbjJq2vzfw/Pu2N88cFxcgqzyICCxvqhU95c yxg/YDFkeWKNMgeA2Iiwi7kY5hil3lXuXzt4YVQ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Kieran Bingham , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.9 130/757] media: i2c: fix error check on max9286_read call Date: Tue, 27 Oct 2020 14:46:20 +0100 Message-Id: <20201027135456.679910299@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit e5b95c8febd504659b60a7601fd43c0ae8e4f3c0 ] Currently the error return from the call to max9286_read is masked with 0xf0 so the following check for a negative error return is never true. Fix this by checking for an error first, then masking the return value for subsequent conflink_mask checking. Addresses-Coverity: ("Logically dead code") Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver") Signed-off-by: Colin Ian King Reviewed-by: Kieran Bingham Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/max9286.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 47f280518fdb6..b364a3f604861 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -405,10 +405,11 @@ static int max9286_check_config_link(struct max9286_priv *priv, * to 5 milliseconds. */ for (i = 0; i < 10; i++) { - ret = max9286_read(priv, 0x49) & 0xf0; + ret = max9286_read(priv, 0x49); if (ret < 0) return -EIO; + ret &= 0xf0; if (ret == conflink_mask) break; -- 2.25.1