From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C218C55178 for ; Tue, 27 Oct 2020 14:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D6C22202 for ; Tue, 27 Oct 2020 14:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809361; bh=fAUpmm08gN4J9wtUSzSkK+j6Tl/1sD2jHmgwo+379/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dV+KBp/uFL5kJLnV4oeQtONoRnZYUhbS1f/UWFkrELk6zeemuA7qvY6j9kxwaLbkd LplCKpAb+3wCHnLvcXICpfgINLSaQUiJCJjBDKrBS/FJW4jZ+VVk5FgKv+hswuifUf 9G4lJqhMaRr8ugLj/hoJLlUmYVf0XcfI2afYAesw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760702AbgJ0Of7 (ORCPT ); Tue, 27 Oct 2020 10:35:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:33886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760560AbgJ0OfK (ORCPT ); Tue, 27 Oct 2020 10:35:10 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DDAA20773; Tue, 27 Oct 2020 14:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809309; bh=fAUpmm08gN4J9wtUSzSkK+j6Tl/1sD2jHmgwo+379/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vgAGGErUtIOVbwPcop/juGkOWiPEz6sSFcgmOEu5YZJb6GgkOqbIf+wq4N3/grsxC bm9sDmM6gFisF+WjFEtx2mxHaCOCv2KdmNP5g0YmeltSER6mN/ROb1gzL4SUfApIPB jTpaz9QdBfjDRv7rmggM5w6S7lim97A6HBLtztsE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Tianjia Zhang , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 120/408] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() Date: Tue, 27 Oct 2020 14:50:58 +0100 Message-Id: <20201027135500.676068294@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianjia Zhang [ Upstream commit ca4fb89a3d714a770e9c73c649da830f3f4a5326 ] On an error exit path, a negative error code should be returned instead of a positive return value. Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Cc: Quinn Tran Signed-off-by: Tianjia Zhang Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index f4815a4084d8c..11656e864fca9 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -682,7 +682,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha) struct nvme_fc_port_template *tmpl; struct qla_hw_data *ha; struct nvme_fc_port_info pinfo; - int ret = EINVAL; + int ret = -EINVAL; if (!IS_ENABLED(CONFIG_NVME_FC)) return ret; -- 2.25.1