From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DD7C55179 for ; Tue, 27 Oct 2020 17:36:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9733821D24 for ; Tue, 27 Oct 2020 17:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603820204; bh=qyiZo9aIKs9oxo6H/sDcKtcMLDUgMZ3Z+/f6vnPjMwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BwJRBje9t8LYDegrIJk3ob3WDK4M91MrpA2M9GPmOhw0fUWZguWBuCJEjYUbU1Qjq sNF24TP1vfXnINyR8j61mNED3stp61ULG/lIsII7xa4ZUdxMGJgC+XRXu4e3YJsAiK 0h5C70fEsNLqMEB5Q341cTkNzoF9WdrA639eMw7c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760793AbgJ0Og3 (ORCPT ); Tue, 27 Oct 2020 10:36:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:34712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760685AbgJ0Ofz (ORCPT ); Tue, 27 Oct 2020 10:35:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2401B22202; Tue, 27 Oct 2020 14:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809354; bh=qyiZo9aIKs9oxo6H/sDcKtcMLDUgMZ3Z+/f6vnPjMwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VITEkqx5vOa46DDEgYuPgWgQ6xxvaOKNUO7HmyQWz7MjsQocejhB4A8EPaGxbEsjH GjQiaabSk5H2eQEFIScnrgeTMufnuSTbJ1KhHe3EFwLWbiFxUAAlaJAjebZWI5M8XP YCyzxdXBQhO4wF5XHVdFYa/lqlC5AXnVBon90xSg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Sasha Levin Subject: [PATCH 5.4 166/408] slimbus: core: do not enter to clock pause mode in core Date: Tue, 27 Oct 2020 14:51:44 +0100 Message-Id: <20201027135502.795711516@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit df2c471c4ae07e18a0396db670dca2ef867c5153 ] Let the controller logic decide when to enter into clock pause mode! Entering in to pause mode during unregistration does not really make sense as the controller is totally going down at that point in time. Fixes: 4b14e62ad3c9e ("slimbus: Add support for 'clock-pause' feature") Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200925095520.27316-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/slimbus/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 42a233fc5dc6c..130c798921b5d 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -302,8 +302,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) { /* Remove all clients */ device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device); - /* Enter Clock Pause */ - slim_ctrl_clk_pause(ctrl, false, 0); ida_simple_remove(&ctrl_ida, ctrl->id); return 0; -- 2.25.1