From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4708C64EBC for ; Tue, 27 Oct 2020 15:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A49A1223AB for ; Tue, 27 Oct 2020 15:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813302; bh=NI1KlFo+3eQwq2WU9SuNO6K26Gtdvyw5xwvm1g5BTyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gc/fIdDbdUf9myIsCg/NspChmEI+JJjjAbqNCmUctWeeq6Dwb00MPbyTah78Jzrpf rjdrv0XncMR3LREog0X2qfOvzccPf7gbD21+a4XF7D7BVPbcL4vnVYJgSoR/oE+tKB uOTE2+I5Xvv11TTPZM37pkV9hipp5f0h3/zxQ9Rs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1800408AbgJ0Pfu (ORCPT ); Tue, 27 Oct 2020 11:35:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:49578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1799610AbgJ0PcZ (ORCPT ); Tue, 27 Oct 2020 11:32:25 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06029206D4; Tue, 27 Oct 2020 15:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812744; bh=NI1KlFo+3eQwq2WU9SuNO6K26Gtdvyw5xwvm1g5BTyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZG9adlCfSFiHrUAo6DqvIaZ+1HDAQ+kk9nHtliBAL5QkuhovS0q7qR1pdZkye7alM ZAdbJ+BmoTOF+5izetqQgXXgHTGfRl8MTm9oUL2cqL4ulRRkbZWG43UuV6qyDhksV2 T8vNkUJdLqGcmNSF/RHOFmeuku5dDm2bhnMyVTX0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Lorenzo Bianconi , Felix Fietkau , Sasha Levin Subject: [PATCH 5.9 316/757] mt76: mt7615: release mutex in mt7615_reset_test_set Date: Tue, 27 Oct 2020 14:49:26 +0100 Message-Id: <20201027135505.361704387@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lorenzo Bianconi [ Upstream commit 346f810e22428cdf73ee5cf2e0ce1b79d5671de5 ] Reduce scope of mutex_acquire/mutex_release in mt7615_reset_test_set routine in order to fix the following static checker warning: drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c:179 mt7615_reset_test_set() warn: inconsistent returns 'dev->mt76.mutex'. Reported-by: Dan Carpenter Fixes: ea4906c4be49 ("mt76: mt7615: wake device before accessing regmap in debugfs") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c index 88931658a9fbb..937cb71bed642 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c @@ -165,15 +165,14 @@ mt7615_reset_test_set(void *data, u64 val) if (!mt7615_wait_for_mcu_init(dev)) return 0; - mt7615_mutex_acquire(dev); - skb = alloc_skb(1, GFP_KERNEL); if (!skb) return -ENOMEM; skb_put(skb, 1); - mt76_tx_queue_skb_raw(dev, 0, skb, 0); + mt7615_mutex_acquire(dev); + mt76_tx_queue_skb_raw(dev, 0, skb, 0); mt7615_mutex_release(dev); return 0; -- 2.25.1