From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBF2C5517A for ; Tue, 27 Oct 2020 14:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB90422264 for ; Tue, 27 Oct 2020 14:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810744; bh=AGYOV/Hmur2XNcduLhRatyeBVAK1wfJ200zWnFeF+1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L2zMDED6IPz42nl23HCFI8LqowAz+O/XMSbQlA6GsiqhXqN/VA9I+qt0KXieRXonV 4mKlyVEo1hkXyXyJzoqHDxwg8HxxHbmU3sr2MmqISrUmbgi2miVdUtT55JUM+YmswC MElhSffaH5uO6h9QuUtFMPNTpMkMXAaedSiJ9eFQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1784333AbgJ0O7D (ORCPT ); Tue, 27 Oct 2020 10:59:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:44610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763116AbgJ0Ooo (ORCPT ); Tue, 27 Oct 2020 10:44:44 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D550521527; Tue, 27 Oct 2020 14:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809884; bh=AGYOV/Hmur2XNcduLhRatyeBVAK1wfJ200zWnFeF+1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nyvwhJdTqxCe1vN6AO/mnbMv2B2yn6Wc8V2RlNeLF88VZ8uFKJjUVHHaICce6yTOr bi4iUP0+UAraXydSqFdUHQUFIyJUjMV6tNRz6lkC+OmHV+BmU9NVU+YDcZNXY6uYPZ 7cm22lwba1nW2xb/rnBc83bU8EpzIf5ZqUng5b0k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Li Yang , Sasha Levin Subject: [PATCH 5.4 312/408] soc: fsl: qbman: Fix return value on success Date: Tue, 27 Oct 2020 14:54:10 +0100 Message-Id: <20201027135509.505152820@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 750cf40c0f7088f36a8a5d102e0488b1ac47faf5 ] On error the function was meant to return -ERRNO. This also fixes compile warning: drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] Fixes: 0505d00c8dba ("soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Li Yang Signed-off-by: Sasha Levin --- drivers/soc/fsl/qbman/bman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index f4fb527d83018..c5dd026fe889f 100644 --- a/drivers/soc/fsl/qbman/bman.c +++ b/drivers/soc/fsl/qbman/bman.c @@ -660,7 +660,7 @@ int bm_shutdown_pool(u32 bpid) } done: put_affine_portal(); - return 0; + return err; } struct gen_pool *bm_bpalloc; -- 2.25.1