Re: [PATCH 5.9 580/757] selftests: mptcp: depends on built-in IPv6

Matthieu Baerts
2020-10-27T16:22:08Z

Hi Greg,

On 27/10/2020 14:53, Greg Kroah-Hartman wrote:
> From: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> [ Upstream commit 287d35405989cfe0090e3059f7788dc531879a8d ]
>
> Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a
> consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no
> longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6
> will stay disabled and selftests will fail.

I think Sasha wanted to drop this patch [1]. But as I said earlier [2],
this patch is not wrong, it is just not needed in v5.9 because the
"Fixes" commit 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6
instead of selecting it") is not in v5.9.

I guess it is certainly easier to keep it because it is not wrong and
doesn't hurt.

[1] https://lore.kernel.org/stable/20201026142329.GJ4060117@sasha-vm/
[2]
https://lore.kernel.org/stable/1de2bf78-4b47-21b0-9d56-3c8063cdf4bb@tessares.net/

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions