From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479FDC388F9 for ; Tue, 27 Oct 2020 15:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAD2822284 for ; Tue, 27 Oct 2020 15:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811196; bh=fBS5LtE5OqagiTeqYn5RUhthV+ThQHXyDy+qSbxygPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YcWITLqpKUop0mbSdFu6zl37Cx8EDhVakkBen/Zek7MWiLCiQVqr/Y2GOGAAL8E4w ru1QL/Q6/TDg7J1BuJlM6P0UsVCwFnd0sRVNYY+CAY0s4hRWDFlAd1Tl8uC92viekL k/pePcNxxvcJRvpMvviaJsvVl7uY7Wj5KFd/gLkM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1790534AbgJ0PEp (ORCPT ); Tue, 27 Oct 2020 11:04:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:35986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1789335AbgJ0PB5 (ORCPT ); Tue, 27 Oct 2020 11:01:57 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83D2320715; Tue, 27 Oct 2020 15:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810917; bh=fBS5LtE5OqagiTeqYn5RUhthV+ThQHXyDy+qSbxygPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uL3wC6lL0h+xuWGdfeSkPErVK85JPCz0NHoEO4jg350H3FkTEHcD/T0V7d++5RUIj tx1Q3NTA+BSipaQUwzhvE/d8ZrbHYogOzAfESVy2vNZ1rVmrYSypbbwLM+gPg1qQLl Raw4N0lTxBstuKGkqOa3TH+DcA3By2oWPZJJ9JTQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Corey Minyard , Tianjia Zhang , Sasha Levin Subject: [PATCH 5.8 307/633] ipmi_si: Fix wrong return value in try_smi_init() Date: Tue, 27 Oct 2020 14:50:50 +0100 Message-Id: <20201027135537.078854373@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianjia Zhang [ Upstream commit 8fe7990ceda8597e407d06bffc4bdbe835a93ece ] On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform devices") Cc: Corey Minyard Signed-off-by: Tianjia Zhang Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com> Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin --- drivers/char/ipmi/ipmi_si_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 77b8d551ae7fe..dd559661c15b3 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -1963,7 +1963,7 @@ static int try_smi_init(struct smi_info *new_smi) /* Do this early so it's available for logs. */ if (!new_smi->io.dev) { pr_err("IPMI interface added with no device\n"); - rv = EIO; + rv = -EIO; goto out_err; } -- 2.25.1