public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hui Su <sh_def@163.com>
To: Michal Hocko <mhocko@suse.com>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,oom_kill: fix the comment of is_dump_unreclaim_slabs()
Date: Tue, 27 Oct 2020 22:32:37 +0800	[thread overview]
Message-ID: <20201027143237.GA2910@rlk> (raw)
In-Reply-To: <20201027071118.GM20500@dhcp22.suse.cz>

On Tue, Oct 27, 2020 at 08:11:18AM +0100, Michal Hocko wrote:
> On Sat 26-09-20 12:15:26, Hui Su wrote:
> > fix the comment of is_dump_unreclaim_slabs(), it just check
> > whether nr_unreclaimable slabs amount is greater than user
> > memory.
> 
> The original comment is meant to say when the function should be used.
> Your update makes the comment makes it a kerneldoc for an internal
> function which on its own is not very useful. It is quite clear what
> the function does. The intention is not clear anymore though.
> 
> If you find the comment confusing, however, then I would just propose either
> dropping it altogether or rename it to should_dump_unreclaimable_slab.
> Which is quite mouthful TBH.
>  

Hi, Michal:

Thanks for your explanation.

I also think maybe we should delete the comment, and change the rename it to
should_dump_unreclaimable_slabs().

Andrew,
Is that ok?


      reply	other threads:[~2020-10-27 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-26  4:15 [PATCH] mm,oom_kill: fix the comment of is_dump_unreclaim_slabs() Hui Su
2020-10-27  7:11 ` Michal Hocko
2020-10-27 14:32   ` Hui Su [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027143237.GA2910@rlk \
    --to=sh_def@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox